code review 11998044: fmt: make all errors begin with the string "%!", always.

fmt: make all errors begin with the string "%!", always.

Fixes Issue 5730.

[kortschak, 2013-07-31 04:57:54]

Hello dsymonds@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[dsymonds, 2013-07-31 05:02:09]

R=r!

[kortschak, 2013-07-31 05:06:03]

On 2013/07/31 05:02:09, dsymonds wrote:
> R=r!

Sorry, +r.

[r, 2013-07-31 05:08:42]

i have one in flight yours is good but please fix doc.go too - line 172 - and
we'll use yours.

[kortschak, 2013-07-31 05:33:56]

PTAL

On 2013/07/31 05:08:42, r wrote:
> i have one in flight yours is good but please fix doc.go too - line 172 - and
> we'll use yours.

Done.

Also made percentBang conform to the names for other []byte.

[kisielk, 2013-07-31 05:35:26]

https://codereview.appspot.com/11998044/diff/15002/src/pkg/fmt/doc.go
File src/pkg/fmt/doc.go (right):

https://codereview.appspot.com/11998044/diff/15002/src/pkg/fmt/doc.go#newcode159
src/pkg/fmt/doc.go:159: Printf("%*[2]d", 7):       %d!(BADINDEX)
These still need to be %!d

[kortschak, 2013-07-31 05:47:16]

PTAL

On 2013/07/31 05:35:26, kisielk wrote:
> https://codereview.appspot.com/11998044/diff/15002/src/pkg/fmt/doc.go
> File src/pkg/fmt/doc.go (right):
> 
>
https://codereview.appspot.com/11998044/diff/15002/src/pkg/fmt/doc.go#newcode159
> src/pkg/fmt/doc.go:159: Printf("%*[2]d", 7):       %d!(BADINDEX)
> These still need to be %!d

Done.

[r, 2013-07-31 05:49:16]

looks good after the one small change, but i'll wait for kisielk's sign-off too
since he owns this

https://codereview.appspot.com/11998044/diff/24001/src/pkg/fmt/print.go
File src/pkg/fmt/print.go (right):

https://codereview.appspot.com/11998044/diff/24001/src/pkg/fmt/print.go#newco...
src/pkg/fmt/print.go:19: percentBangBytes = []byte("%!")
move this down with the other error ones, before MISSING, to group it with them.

[kisielk, 2013-07-31 05:54:16]

LGTM

[kortschak, 2013-07-31 05:57:16]

On 2013/07/31 05:49:16, r wrote:
> looks good after the one small change, but i'll wait for kisielk's sign-off
too
> since he owns this
> 
> https://codereview.appspot.com/11998044/diff/24001/src/pkg/fmt/print.go
> File src/pkg/fmt/print.go (right):
> 
>
https://codereview.appspot.com/11998044/diff/24001/src/pkg/fmt/print.go#newco...
> src/pkg/fmt/print.go:19: percentBangBytes = []byte("%!")
> move this down with the other error ones, before MISSING, to group it with
them.

Done.

[r, 2013-07-31 06:08:51]

LGTM

[r, 2013-07-31 06:11:17]

*** Submitted as https://code.google.com/p/go/source/detail?r=09a1cf0d94b2 ***

fmt: make all errors begin with the string "%!", always.

Fixes Issue 5730.

R=dsymonds, r, kamil.kisiel
CC=golang-dev
https://codereview.appspot.com/11998044

Committer: Rob Pike <r@golang.org>