Issue 11984043: code review 11984043: net: document sockaddr interface

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11984043: code review 11984043: net: document sockaddr interface (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by mikio

Modified:
10 years, 9 months ago

Reviewers:
dave

CC:
golang-dev, fvb, dave_cheney.net

Visibility:
Public.

Description

net: document sockaddr interface This is in preparation for runtime-integrated network pollster for BSD variants. Update issue 5199

Patch Set 2 : diff -r 2fe813f4f3c2 https://code.google.com/p/go #

Patch Set 3 : diff -r 2fe813f4f3c2 https://code.google.com/p/go #

Patch Set 4 : diff -r 2fe813f4f3c2 https://code.google.com/p/go #

Total comments: 2

Patch Set 5 : diff -r 2fe813f4f3c2 https://code.google.com/p/go #

Patch Set 6 : diff -r 2690daea28ad https://code.google.com/p/go #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -0 lines)			Patch
	M	src/pkg/net/sock_posix.go	View	1 2 3 4	1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

mikio

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

10 years, 9 months ago (2013-07-28 10:43:22 UTC) #1

mikio

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.

10 years, 9 months ago (2013-07-28 10:44:30 UTC) #2

fvb

https://codereview.appspot.com/11984043/diff/8001/src/pkg/net/sock_posix.go File src/pkg/net/sock_posix.go (right): https://codereview.appspot.com/11984043/diff/8001/src/pkg/net/sock_posix.go#newcode27 src/pkg/net/sock_posix.go:27: // sockaddr retunrs the address converted into a syscall ...

10 years, 9 months ago (2013-07-28 11:19:00 UTC) #3

mikio

ptal https://codereview.appspot.com/11984043/diff/8001/src/pkg/net/sock_posix.go File src/pkg/net/sock_posix.go (right): https://codereview.appspot.com/11984043/diff/8001/src/pkg/net/sock_posix.go#newcode27 src/pkg/net/sock_posix.go:27: // sockaddr retunrs the address converted into a ...

10 years, 9 months ago (2013-07-28 11:26:53 UTC) #4

mikio

10 years, 9 months ago (2013-07-29 14:25:48 UTC) #6

*** Submitted as https://code.google.com/p/go/source/detail?r=8c1cb8e761fb ***

net: document sockaddr interface

This is in preparation for runtime-integrated network pollster for BSD
variants.

Update issue 5199

R=golang-dev, fvbommel, dave
CC=golang-dev
https://codereview.appspot.com/11984043

Expand All Messages | Collapse All Messages