Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(923)

Issue 11979043: code review 11979043: net: extend sockaddr interface to the all address families (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by mikio
Modified:
10 years, 8 months ago
Reviewers:
dfc
CC:
golang-dev, dfc
Visibility:
Public.

Description

net: extend sockaddr interface to the all address families This CL extends existing sockaddr interface to accommodate not only internet protocol family endpoint addressess but unix network family endpoint addresses. This is in preparation for runtime-integrated network pollster for BSD variants. Update issue 5199

Patch Set 1 #

Patch Set 2 : diff -r f0e11bcf7c1d https://code.google.com/p/go #

Patch Set 3 : diff -r f0e11bcf7c1d https://code.google.com/p/go #

Total comments: 1

Patch Set 4 : diff -r f0e11bcf7c1d https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M src/pkg/net/ipsock_posix.go View 1 1 chunk +0 lines, -9 lines 0 comments Download
M src/pkg/net/sock_posix.go View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 3
mikio
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
10 years, 8 months ago (2013-07-28 03:33:07 UTC) #1
dfc
LGTM. Thank you for splitting this up. https://codereview.appspot.com/11979043/diff/5001/src/pkg/net/sock_posix.go File src/pkg/net/sock_posix.go (right): https://codereview.appspot.com/11979043/diff/5001/src/pkg/net/sock_posix.go#newcode14 src/pkg/net/sock_posix.go:14: // A ...
10 years, 8 months ago (2013-07-28 03:44:18 UTC) #2
mikio
10 years, 8 months ago (2013-07-28 03:52:38 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=cfaef1dc8164 ***

net: extend sockaddr interface to the all address families

This CL extends existing sockaddr interface to accommodate not only
internet protocol family endpoint addressess but unix network family
endpoint addresses.

This is in preparation for runtime-integrated network pollster for BSD
variants.

Update issue 5199

R=golang-dev, dave
CC=golang-dev
https://codereview.appspot.com/11979043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b