Issue 119600043: code review 119600043: os: simplify windows Getwd (fixes build)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 119600043: code review 119600043: os: simplify windows Getwd (fixes build) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 8 months ago by brainman

Modified:
9 years, 8 months ago

Reviewers:
minux

CC:
golang-codereviews, minux

Visibility:
Public.

Description

os: simplify windows Getwd (fixes build) Current version of Getwd calls Stat that calls Getwd therefore infinite recursion.

Patch Set 1 #

Patch Set 2 : diff -r 66ccfb5353a8281aca6816d5d3a40aacd860638e https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 66ccfb5353a8281aca6816d5d3a40aacd860638e https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 66ccfb5353a8281aca6816d5d3a40aacd860638e https://go.googlecode.com/hg/ #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	src/pkg/os/getwd.go	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

brainman

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

9 years, 8 months ago (2014-08-08 00:00:10 UTC) #1

brainman

9 years, 8 months ago (2014-08-08 00:09:38 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=f16943857e65 ***

os: simplify windows Getwd (fixes build)

Current version of Getwd calls Stat that
calls Getwd therefore infinite recursion.

LGTM=minux
R=golang-codereviews, minux
CC=golang-codereviews
https://codereview.appspot.com/119600043

Expand All Messages | Collapse All Messages