Issue 11920043: code review 11920043: go.image/tiff: Support reading 16-bit gray images.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11920043: code review 11920043: go.image/tiff: Support reading 16-bit gray images. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by bsiegert

Modified:
9 years, 10 months ago

Reviewers:
nigeltao

CC:
nigeltao, golang-dev

Visibility:
Public.

Description

go.image/tiff: Support reading 16-bit gray images. Fixes issue 5866.

Patch Set 2 : diff -r d16be1f828b0 https://code.google.com/p/go.image #

Patch Set 3 : diff -r d16be1f828b0 https://code.google.com/p/go.image #

Total comments: 4

Patch Set 4 : diff -r d16be1f828b0 https://code.google.com/p/go.image #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -19 lines)			Patch
	M	tiff/reader.go	View	1 2 3	6 chunks	+46 lines, -19 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

bsiegert

Hello nigeltao@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.image

10 years, 9 months ago (2013-07-26 14:43:50 UTC) #1

nigeltao

https://codereview.appspot.com/11920043/diff/5001/tiff/reader.go File tiff/reader.go (right): https://codereview.appspot.com/11920043/diff/5001/tiff/reader.go#newcode203 tiff/reader.go:203: switch d.bpp { if d.bpp == 16 { etc ...

10 years, 9 months ago (2013-07-28 10:09:41 UTC) #2

bsiegert

Hello nigeltao@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

10 years, 9 months ago (2013-07-29 13:41:13 UTC) #3

bsiegert

10 years, 9 months ago (2013-07-29 13:41:54 UTC) #4

nigeltao

10 years, 9 months ago (2013-07-30 05:02:43 UTC) #6

*** Submitted as
https://code.google.com/p/go/source/detail?r=ed7988a0510c&repo=image ***

go.image/tiff: Support reading 16-bit gray images.

Fixes issue 5866.

R=nigeltao
CC=golang-dev
https://codereview.appspot.com/11920043

Committer: Nigel Tao <nigeltao@golang.org>

Expand All Messages | Collapse All Messages