Issue 11904043: code review 11904043: cmd/pack: support removing of leading file prefix on windows

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11904043: code review 11904043: cmd/pack: support removing of leading file prefix on windows (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by brainman

Modified:
11 years, 8 months ago

Reviewers:
r

CC:
golang-dev, r

Visibility:
Public.

Description

cmd/pack: support removing of leading file prefix on windows Fixes issue 5550

Patch Set 2 : diff -r 8bbeea196139 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 8bbeea196139 https://go.googlecode.com/hg/ #

Total comments: 4

Patch Set 4 : diff -r 8bbeea196139 https://go.googlecode.com/hg/ #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -3 lines)			Patch
	M	src/cmd/pack/ar.c	View	1 2 3	3 chunks	+25 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

brainman

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 8 months ago (2013-07-26 06:13:19 UTC) #1

LGTM https://codereview.appspot.com/11904043/diff/5001/src/cmd/pack/ar.c File src/cmd/pack/ar.c (right): https://codereview.appspot.com/11904043/diff/5001/src/cmd/pack/ar.c#newcode1624 src/cmd/pack/ar.c:1624: * checks if p is start of windows ...

11 years, 8 months ago (2013-07-26 06:35:53 UTC) #2

brainman

11 years, 8 months ago (2013-07-26 06:56:32 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=6d555b7f39bd ***

cmd/pack: support removing of leading file prefix on windows

Fixes issue 5550

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/11904043

https://codereview.appspot.com/11904043/diff/5001/src/cmd/pack/ar.c
File src/cmd/pack/ar.c (right):

https://codereview.appspot.com/11904043/diff/5001/src/cmd/pack/ar.c#newcode1624
src/cmd/pack/ar.c:1624: *	checks if p is start of windows full path, like C:\ or
c:/.
On 2013/07/26 06:35:53, r wrote:
> s/checks/check/ for consistency

Done.

https://codereview.appspot.com/11904043/diff/5001/src/cmd/pack/ar.c#newcode1625
src/cmd/pack/ar.c:1625: *	returns 1 if so. also sets drive parameter to its
On 2013/07/26 06:35:53, r wrote:
> s/returns/return/
> s/sets/set/

Done.

Expand All Messages | Collapse All Messages