Issue 118970043: code review 118970043: os: in Getwd, $PWD override syscall.Getwd

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 118970043: code review 118970043: os: in Getwd, $PWD override syscall.Getwd (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 9 months ago by rsc

Modified:
9 years, 8 months ago

Reviewers:
gobot, bradfitz

CC:
iant, bradfitz, golang-codereviews

Visibility:
Public.

Description

os: in Getwd, $PWD override syscall.Getwd This makes os.Getwd mimic C getwd on OS X, and possibly other systems. The change on OS X was a regression from 1.2 to 1.3. Fixes issue 8400.

Patch Set 2 : diff -r c5aaab784278 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 70a668a2e09e1587fee166f92c265861c57a490f https://code.google.com/p/go/ #

Total comments: 2

Patch Set 4 : diff -r 59acd3398f71d6315bbebbadb4dd77f7e58757cd https://code.google.com/p/go/ #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -14 lines)			Patch
	M	src/pkg/os/getwd.go	View	1 2	2 chunks	+11 lines, -12 lines	0 comments	Download
	M	src/pkg/os/os_test.go	View	1 2	3 chunks	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

rsc

Hello iant (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

9 years, 8 months ago (2014-08-06 20:55:44 UTC) #1

bradfitz

https://codereview.appspot.com/118970043/diff/30001/src/pkg/os/getwd.go File src/pkg/os/getwd.go (right): https://codereview.appspot.com/118970043/diff/30001/src/pkg/os/getwd.go#newcode28 src/pkg/os/getwd.go:28: dot, err := Stat(".") this is unused and unnecessary ...

9 years, 8 months ago (2014-08-06 21:09:29 UTC) #2

rsc

9 years, 8 months ago (2014-08-06 21:39:51 UTC) #3

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=4bba86195874 *** os: in Getwd, $PWD override syscall.Getwd This makes os.Getwd mimic ...

9 years, 8 months ago (2014-08-07 12:58:28 UTC) #5

gobot

9 years, 8 months ago (2014-08-07 13:00:19 UTC) #6

Message was sent while issue was closed.

This CL appears to have broken the windows-amd64-race builder.
See http://build.golang.org/log/300dde71e9e94719428550e8fc0250d746ce1c2e

Expand All Messages | Collapse All Messages