Issue 11894043: code review 11894043: gc: fix line directive processing on windows

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11894043: code review 11894043: gc: fix line directive processing on windows (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by brainman

Modified:
11 years, 8 months ago

Reviewers:
rsc

CC:
golang-dev, rsc

Visibility:
Public.

Description

gc: fix line directive processing on windows This change should have been part of 5671737303a0. Fixes issue 5904

Patch Set 1 #

Patch Set 2 : diff -r b70ee935c690 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r b70ee935c690 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r b70ee935c690 https://go.googlecode.com/hg/ #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/cmd/gc/obj.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

brainman

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 8 months ago (2013-07-26 02:17:56 UTC) #1

rsc

LGTM There is no need to undo the other change. The other change handles a ...

11 years, 8 months ago (2013-07-26 03:01:46 UTC) #3

brainman

11 years, 8 months ago (2013-07-26 03:38:34 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=8bbeea196139 ***

gc: fix line directive processing on windows

This change should have been part of 5671737303a0.

Fixes issue 5904

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/11894043

Expand All Messages | Collapse All Messages