code review 11888043: 5c: fix pc recalculation in the presence of AFUNCDATA

5c: fix pc recalculation in the presence of AFUNCDATA

This makes CL 11683043 not break arm anymore.

[khr, 2013-07-26 00:11:13]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://khr%40golang.org@code.google.com/p/go/

[bradfitz, 2013-07-26 00:12:58]

LGTM



On Thu, Jul 25, 2013 at 5:11 PM, <khr@golang.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
>
https://khr%40golang.org@code.**google.com/p/go/<http://40golang.org@code.goo...
>
>
> Description:
> 5c: fix pc recalculation in the presence of AFUNCDATA
>
> This makes CL 11683043 not break arm anymore.
>
> Please review this at
https://codereview.appspot.**com/11888043/<https://codereview.appspot.com/118...
>
> Affected files:
>   M src/cmd/5c/reg.c
>
>
> Index: src/cmd/5c/reg.c
> ==============================**==============================**=======
> --- a/src/cmd/5c/reg.c
> +++ b/src/cmd/5c/reg.c
> @@ -461,6 +461,7 @@
>                         case AGLOBL:
>                         case ANAME:
>                         case ASIGNAME:
> +                       case AFUNCDATA:
>                                 break;
>                         }
>                 }
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[dave_cheney.net, 2013-07-26 00:36:35]

LGTM. Not tested, but we have lots of arm systems that will squeak if
this is wrong.

On Fri, Jul 26, 2013 at 10:12 AM, Brad Fitzpatrick <bradfitz@golang.org> wrote:
> LGTM
>
>
>
> On Thu, Jul 25, 2013 at 5:11 PM, <khr@golang.org> wrote:
>>
>> Reviewers: golang-dev1,
>>
>> Message:
>> Hello golang-dev@googlegroups.com,
>>
>> I'd like you to review this change to
>> https://khr%40golang.org@code.google.com/p/go/
>>
>>
>> Description:
>> 5c: fix pc recalculation in the presence of AFUNCDATA
>>
>> This makes CL 11683043 not break arm anymore.
>>
>> Please review this at https://codereview.appspot.com/11888043/
>>
>> Affected files:
>>   M src/cmd/5c/reg.c
>>
>>
>> Index: src/cmd/5c/reg.c
>> ===================================================================
>> --- a/src/cmd/5c/reg.c
>> +++ b/src/cmd/5c/reg.c
>> @@ -461,6 +461,7 @@
>>                         case AGLOBL:
>>                         case ANAME:
>>                         case ASIGNAME:
>> +                       case AFUNCDATA:
>>                                 break;
>>                         }
>>                 }
>>
>>
>> --
>>
>> ---You received this message because you are subscribed to the Google
>> Groups "golang-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to golang-dev+unsubscribe@googlegroups.com.
>> For more options, visit https://groups.google.com/groups/opt_out.
>>
>>
>
> --
>
> ---
> You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>

[khr, 2013-07-26 00:40:32]

*** Submitted as https://code.google.com/p/go/source/detail?r=a4a5aa51849c ***

5c: fix pc recalculation in the presence of AFUNCDATA

This makes CL 11683043 not break arm anymore.

R=golang-dev, bradfitz, dave
CC=golang-dev
https://codereview.appspot.com/11888043

[DMorsing, 2013-07-26 11:39:09]

On Fri, Jul 26, 2013 at 2:40 AM,  <khr@golang.org> wrote:
> *** Submitted as
> https://code.google.com/p/go/source/detail?r=a4a5aa51849c ***
>
>
> 5c: fix pc recalculation in the presence of AFUNCDATA
>
> This makes CL 11683043 not break arm anymore.
>
> R=golang-dev, bradfitz, dave
> CC=golang-dev
> https://codereview.appspot.com/11888043
>
>
> https://codereview.appspot.com/11888043/
>
>

This step is missing for cmd/*g and I think there's a couple of other
spots that needs to be informed of FUNCDATA as well.

The easiest way to figure this out is to grep for ATYPE and do the
same for FUNCDATA.

[rsc, 2013-07-26 17:53:50]

It's not entirely clear to me that FUNCDATA should be handled like TYPE.
TYPE could be elided after processing during input. FUNCDATA must stick
around longer.

Russ