Issue 11887043: code review 11887043: [release-branch.go1.1] cmd/cgo: gccgo fixes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11887043: code review 11887043: [release-branch.go1.1] cmd/cgo: gccgo fixes (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by adg

Modified:
10 years, 9 months ago

Reviewers:
dave

CC:
golang-dev, dave_cheney.net

Visibility:
Public.

Description

[release-branch.go1.1] cmd/cgo: gccgo fixes ««« CL 11406047 / 4d9c3095de9d cmd/cgo: gccgo fixes Don't require a full-scale callback for calls to the special prologue functions. Always use a simple wrapper function for C functions, so that we can handle static functions defined in the import "C" comment. Disable a test that relies on gc-specific function names. Fixes issue 5905. R=golang-dev, rsc CC=golang-dev https://codereview.appspot.com/11406047 Committer: Russ Cox <rsc@golang.org> »»» Update issue 5928

Patch Set 1 #

Patch Set 2 : diff -r 8c514a33ecd0 https://code.google.com/p/go #

Patch Set 3 : diff -r 8c514a33ecd0 https://code.google.com/p/go #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -6 lines)			Patch
	M	misc/cgo/test/callback.go	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
	M	src/cmd/cgo/out.go	View	1	6 chunks	+62 lines, -6 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

10 years, 9 months ago (2013-07-26 00:05:35 UTC) #1

dave_cheney.net

On 2013/07/26 00:05:35, adg wrote: > Hello mailto:golang-dev@googlegroups.com, > > I'd like you to review ...

10 years, 9 months ago (2013-07-28 00:39:10 UTC) #2

adg

10 years, 9 months ago (2013-07-28 23:58:04 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=4e2d025187c6 ***

[release-branch.go1.1] cmd/cgo: gccgo fixes

««« CL 11406047 / 4d9c3095de9d
cmd/cgo: gccgo fixes

Don't require a full-scale callback for calls to the special
prologue functions.

Always use a simple wrapper function for C functions, so that
we can handle static functions defined in the import "C"
comment.

Disable a test that relies on gc-specific function names.

Fixes issue 5905.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/11406047

Committer: Russ Cox <rsc@golang.org>
»»»

Update issue 5928

R=golang-dev, dave
CC=golang-dev
https://codereview.appspot.com/11887043

Expand All Messages | Collapse All Messages