Issue 118670043: code review 118670043: runtime: turn off 'unexpected return pc' print on arm t...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 118670043: code review 118670043: runtime: turn off 'unexpected return pc' print on arm t... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 8 months ago by rsc

Modified:
9 years, 8 months ago

Reviewers:
minux

CC:
golang-codereviews, minux, iant, r

Visibility:
Public.

Description

runtime: turn off 'unexpected return pc' print on arm traceback It can happen legitimately if a profiling signal arrives at just the wrong moment. It's harmless. Fixes issue 8153.

Patch Set 1 #

Patch Set 2 : diff -r 957bd50e2b82 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 957bd50e2b82 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 957bd50e2b82 https://code.google.com/p/go/ #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	src/pkg/runtime/traceback_arm.c	View		1 chunk	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello golang-codereviews@googlegroups.com (cc: iant, r), I'd like you to review this change to https://code.google.com/p/go/

9 years, 8 months ago (2014-08-06 18:33:58 UTC) #1

minux

LGTM. I also observe it happens on power64 port without profiling enabled, and callback is ...

9 years, 8 months ago (2014-08-06 18:36:52 UTC) #2

rsc

Well, there's no guarantee that power64 isn't broken in some other way. I wouldn't conclude ...

9 years, 8 months ago (2014-08-06 18:49:51 UTC) #3

rsc

9 years, 8 months ago (2014-08-06 18:50:13 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=671fa8a9eb80 ***

runtime: turn off 'unexpected return pc' print on arm traceback

It can happen legitimately if a profiling signal arrives at just the wrong
moment.
It's harmless.

Fixes issue 8153.

LGTM=minux
R=golang-codereviews, minux
CC=golang-codereviews, iant, r
https://codereview.appspot.com/118670043

Expand All Messages | Collapse All Messages