Issue 11818043: code review 11818043: go-tour: various expansions and clarifications

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11818043: code review 11818043: go-tour: various expansions and clarifications (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by adg

Modified:
10 years, 10 months ago

Reviewers:
r

CC:
golang-dev, r

Visibility:
Public.

Description

go-tour: various expansions and clarifications All of these are in response to user feedback. Fixes issue 66. Fixes issue 74. Fixes issue 80. Fixes issue 83. Fixes issue 86. Fixes issue 88.

Patch Set 1 #

Patch Set 2 : diff -r de629fc566eb https://code.google.com/p/go-tour #

Patch Set 3 : diff -r de629fc566eb https://code.google.com/p/go-tour #

Patch Set 4 : diff -r de629fc566eb https://code.google.com/p/go-tour #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -7 lines)			Patch
	M	prog/packages.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
	M	tour.article	View	1 2	6 chunks	+12 lines, -5 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go-tour

10 years, 10 months ago (2013-07-25 05:44:41 UTC) #1

adg

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.

10 years, 10 months ago (2013-07-25 06:09:07 UTC) #2

LGTM but your closure description will be visited again, i promise

10 years, 10 months ago (2013-07-25 06:12:38 UTC) #3

adg

10 years, 10 months ago (2013-07-25 06:13:49 UTC) #4

*** Submitted as https://code.google.com/p/go-tour/source/detail?r=c7a813b25782
***

go-tour: various expansions and clarifications

All of these are in response to user feedback.

Fixes issue 66.
Fixes issue 74.
Fixes issue 80.
Fixes issue 83.
Fixes issue 86.
Fixes issue 88.

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/11818043

Expand All Messages | Collapse All Messages