Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1206)

Issue 11813043: code review 11813043: go/parser: restrict ParseDir to files with suffix ".go" (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by gri
Modified:
10 years, 8 months ago
Reviewers:
r, rsc
CC:
rsc, r, golang-dev
Visibility:
Public.

Description

go/parser: restrict ParseDir to files with suffix ".go" Fixes issue 5956.

Patch Set 1 #

Patch Set 2 : diff -r 40bbcafc819c https://code.google.com/p/go/ #

Patch Set 3 : diff -r 40bbcafc819c https://code.google.com/p/go/ #

Patch Set 4 : diff -r 40bbcafc819c https://code.google.com/p/go/ #

Patch Set 5 : diff -r e57647a91b11 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -14 lines) Patch
M src/pkg/go/parser/interface.go View 1 2 3 chunks +9 lines, -6 lines 0 comments Download
M src/pkg/go/parser/parser_test.go View 1 2 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 4
gri
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
10 years, 8 months ago (2013-07-25 05:06:33 UTC) #1
r
LGTM
10 years, 8 months ago (2013-07-25 05:23:44 UTC) #2
rsc
LGTM
10 years, 8 months ago (2013-07-25 13:39:01 UTC) #3
gri
10 years, 8 months ago (2013-07-25 16:36:23 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=b9ee7a3df1c9 ***

go/parser: restrict ParseDir to files with suffix ".go"

Fixes issue 5956.

R=rsc, r
CC=golang-dev
https://codereview.appspot.com/11813043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b