Issue 118120043: code review 118120043: runtime: rename throwgo to gothrow

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 118120043: code review 118120043: runtime: rename throwgo to gothrow (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by dave

Modified:
10 years, 8 months ago

Reviewers:
dvyukov

CC:
golang-codereviews, dvyukov

Visibility:
Public.

Description

runtime: rename throwgo to gothrow As pointed out by Elias Naur, the convention for Go runtime functions means this function should be named gothrow. Discussion: https://codereview.appspot.com/115860045/#msg6

Patch Set 1 #

Patch Set 2 : diff -r f97fb06525e5 https://code.google.com/p/go #

Patch Set 3 : diff -r da1002b78b19 https://code.google.com/p/go #

Patch Set 4 : diff -r da1002b78b19 https://code.google.com/p/go #

Patch Set 5 : diff -r da1002b78b19 https://code.google.com/p/go #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -15 lines)			Patch
M	src/pkg/runtime/hashmap.go	View	6 chunks	+13 lines, -13 lines	0 comments	Download
M	src/pkg/runtime/panic.c	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/stubs.go	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dave_cheney.net

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

10 years, 8 months ago (2014-07-22 10:58:25 UTC) #1

dave_cheney.net

10 years, 8 months ago (2014-07-22 21:09:30 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=6a4157362cfd ***

runtime: rename throwgo to gothrow

As pointed out by Elias Naur, the convention for Go runtime functions means this
function should be named gothrow.

Discussion: https://codereview.appspot.com/115860045/#msg6

LGTM=dvyukov
R=golang-codereviews, dvyukov
CC=golang-codereviews
https://codereview.appspot.com/118120043

Expand All Messages | Collapse All Messages