Issue 11811043: code review 11811043: net: a bit useful panic recovery message in test

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11811043: code review 11811043: net: a bit useful panic recovery message in test (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by mikio

Modified:
11 years, 8 months ago

Reviewers:
dave

CC:
golang-dev, dave_cheney.net

Visibility:
Public.

Description

net: give more detail when test panics

Patch Set 1 #

Patch Set 2 : diff -r 3ffbc06b4874 https://code.google.com/p/go #

Patch Set 3 : diff -r 3ffbc06b4874 https://code.google.com/p/go #

Patch Set 4 : diff -r 3ffbc06b4874 https://code.google.com/p/go #

Total comments: 2

Patch Set 5 : diff -r ba52f6399462 https://code.google.com/p/go #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	src/pkg/net/interface_linux_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	src/pkg/net/unicast_posix_test.go	View	1 2 3 4	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

mikio

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

11 years, 8 months ago (2013-07-25 03:41:30 UTC) #1

mikio

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.

11 years, 8 months ago (2013-07-25 03:44:08 UTC) #2

dave_cheney.net

LGTM. I suggest this issue title. net: give more detail when test panics. https://codereview.appspot.com/11811043/diff/1002/src/pkg/net/unicast_posix_test.go File ...

11 years, 8 months ago (2013-07-25 11:04:57 UTC) #3

mikio

11 years, 8 months ago (2013-07-25 15:21:44 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=c325c920ac3f ***

net: give more detail when test panics

R=golang-dev, dave
CC=golang-dev
https://codereview.appspot.com/11811043

https://codereview.appspot.com/11811043/diff/1002/src/pkg/net/unicast_posix_t...
File src/pkg/net/unicast_posix_test.go (right):

https://codereview.appspot.com/11811043/diff/1002/src/pkg/net/unicast_posix_t...
src/pkg/net/unicast_posix_test.go:440: t.Fatalf("Listen, ListenPacket or
subsidiaries panicked: %v", p)
On 2013/07/25 11:04:57, dfc wrote:
> subsidiaries ?

Done.

Expand All Messages | Collapse All Messages