Issue 118020043: code review 118020043: make.bat: do not exit builder on successful completion ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 118020043: code review 118020043: make.bat: do not exit builder on successful completion ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by brainman

Modified:
10 years, 7 months ago

Reviewers:
dvyukov

CC:
golang-codereviews, dvyukov

Visibility:
Public.

Description

make.bat: do not exit builder on successful completion of make.bat (fixes build)

Patch Set 1 #

Patch Set 2 : diff -r bbddc25284e9 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r bbddc25284e9 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r bbddc25284e9 https://go.googlecode.com/hg/ #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/make.bat	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

brainman

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

10 years, 8 months ago (2014-07-21 00:59:02 UTC) #1

brainman

# grep make.bat all.bat race.bat all.bat:if exist make.bat goto ok all.bat:call make.bat --no-banner --no-local race.bat:if ...

10 years, 8 months ago (2014-07-21 01:02:43 UTC) #2

brainman

10 years, 7 months ago (2014-07-21 06:29:46 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=82cbf874e066 ***

make.bat: do not exit builder on successful completion of make.bat (fixes build)

LGTM=dvyukov
R=golang-codereviews, dvyukov
CC=golang-codereviews
https://codereview.appspot.com/118020043

Expand All Messages | Collapse All Messages