Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(920)

Issue 11789043: code review 11789043: undo CL 11788043 / 62d06cccc261 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by khr
Modified:
11 years, 8 months ago
Reviewers:
dave, rsc
CC:
dave, golang-dev
Visibility:
Public.

Description

undo CL 11788043 / 62d06cccc261 Reason for breakage fixed with CL 11888043. ««« original CL description undo CL 11683043 / bb75d03e6ccb Broke arm build. R=dave ««« original CL description cc: generate argument pointer maps for C functions. R=golang-dev, rsc CC=golang-dev https://codereview.appspot.com/11683043 »»» R=golang-dev CC=golang-dev https://codereview.appspot.com/11788043 »»»

Patch Set 1 #

Patch Set 2 : diff -r a4a5aa51849c https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 3 : diff -r a4a5aa51849c https://khr%40golang.org@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -14 lines) Patch
M src/cmd/cc/pgen.c View 1 5 chunks +120 lines, -14 lines 0 comments Download

Messages

Total messages: 4
khr
Hello dave (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://khr%40golang.org@code.google.com/p/go/
11 years, 8 months ago (2013-07-26 00:51:31 UTC) #1
khr
*** Submitted as https://code.google.com/p/go/source/detail?r=b70ee935c690 *** undo CL 11788043 / 62d06cccc261 Reason for breakage fixed with ...
11 years, 8 months ago (2013-07-26 00:51:35 UTC) #2
dave_cheney.net
Never tried to undo an undo. LGTM. On Fri, Jul 26, 2013 at 10:51 AM, ...
11 years, 8 months ago (2013-07-26 00:53:14 UTC) #3
rsc
11 years, 8 months ago (2013-07-26 03:05:07 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b