Issue 11788043: code review 11788043: undo CL 11683043 / bb75d03e6ccb

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11788043: code review 11788043: undo CL 11683043 / bb75d03e6ccb (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by khr

Modified:
11 years, 8 months ago

Reviewers:

CC:
golang-dev

Visibility:
Public.

Description

undo CL 11683043 / bb75d03e6ccb Broke arm build. R=dave ««« original CL description cc: generate argument pointer maps for C functions. R=golang-dev, rsc CC=golang-dev https://codereview.appspot.com/11683043 »»»

Patch Set 1 #

Patch Set 2 : diff -r 5990f8211e89 https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 3 : diff -r 5990f8211e89 https://khr%40golang.org@code.google.com/p/go/ #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -121 lines)			Patch
	M	src/cmd/cc/pgen.c	View	1	5 chunks	+14 lines, -121 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

khr

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://khr%40golang.org@code.google.com/p/go/

11 years, 8 months ago (2013-07-24 22:04:02 UTC) #1

khr

11 years, 8 months ago (2013-07-24 22:04:13 UTC) #2

*** Submitted as https://code.google.com/p/go/source/detail?r=62d06cccc261 ***

undo CL 11683043 / bb75d03e6ccb

Broke arm build.
R=dave

««« original CL description
cc: generate argument pointer maps for C functions.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/11683043
»»»

R=golang-dev
CC=golang-dev
https://codereview.appspot.com/11788043

Expand All Messages | Collapse All Messages