Oh, you may need to add // +build none to all your examples to avoid ...
9 years, 8 months ago
(2014-07-12 06:35:44 UTC)
#3
Oh, you may need to add // +build none to all your examples to avoid
breaking the build
# code.google.com/p/go.talks/2014/compiling
2014/compiling/const2.go:6: C1 redeclared in this block
previous declaration at 2014/compiling/const1.go:6
2014/compiling/const2.go:7: C2 redeclared in this block
previous declaration at 2014/compiling/const1.go:8
2014/compiling/const2.go:8: C3 redeclared in this block
previous declaration at 2014/compiling/const1.go:9
2014/compiling/const2.go:14: main redeclared in this block
previous declaration at 2014/compiling/const1.go:14
2014/compiling/const3.go:9: V1 redeclared in this block
previous declaration at 2014/compiling/const2.go:10
2014/compiling/const3.go:10: V2 redeclared in this block
previous declaration at 2014/compiling/const2.go:11
2014/compiling/const3.go:12: main redeclared in this block
previous declaration at 2014/compiling/const2.go:14
2014/compiling/name1.go:7: main redeclared in this block
previous declaration at 2014/compiling/const3.go:12
2014/compiling/name2.go:7: main redeclared in this block
previous declaration at 2014/compiling/name1.go:7
2014/compiling/name2.go:19: T redeclared in this block
previous declaration at 2014/compiling/name1.go:19
On Sat, Jul 12, 2014 at 3:43 PM, <dave@cheney.net> wrote:
> LGTM. I'm sorry I didn't get to see your talk in person.
>
> https://codereview.appspot.com/117720043/
On 2014/07/12 06:35:44, dfc wrote: > Oh, you may need to add // +build none ...
9 years, 8 months ago
(2014-07-12 14:52:09 UTC)
#5
On 2014/07/12 06:35:44, dfc wrote:
> Oh, you may need to add // +build none to all your examples to avoid
> breaking the build
Done, thanks.
> # code.google.com/p/go.talks/2014/compiling
> 2014/compiling/const2.go:6: C1 redeclared in this block
> previous declaration at 2014/compiling/const1.go:6
> 2014/compiling/const2.go:7: C2 redeclared in this block
> previous declaration at 2014/compiling/const1.go:8
> 2014/compiling/const2.go:8: C3 redeclared in this block
> previous declaration at 2014/compiling/const1.go:9
> 2014/compiling/const2.go:14: main redeclared in this block
> previous declaration at 2014/compiling/const1.go:14
> 2014/compiling/const3.go:9: V1 redeclared in this block
> previous declaration at 2014/compiling/const2.go:10
> 2014/compiling/const3.go:10: V2 redeclared in this block
> previous declaration at 2014/compiling/const2.go:11
> 2014/compiling/const3.go:12: main redeclared in this block
> previous declaration at 2014/compiling/const2.go:14
> 2014/compiling/name1.go:7: main redeclared in this block
> previous declaration at 2014/compiling/const3.go:12
> 2014/compiling/name2.go:7: main redeclared in this block
> previous declaration at 2014/compiling/name1.go:7
> 2014/compiling/name2.go:19: T redeclared in this block
> previous declaration at 2014/compiling/name1.go:19
>
> On Sat, Jul 12, 2014 at 3:43 PM, <mailto:dave@cheney.net> wrote:
> > LGTM. I'm sorry I didn't get to see your talk in person.
> >
> > https://codereview.appspot.com/117720043/
On 2014/07/12 14:52:25, iant wrote: > On 2014/07/12 08:54:34, kortschak wrote: > > mv compiling.slide ...
9 years, 8 months ago
(2014-07-12 22:02:56 UTC)
#7
On 2014/07/12 14:52:25, iant wrote:
> On 2014/07/12 08:54:34, kortschak wrote:
> > mv compiling.slide ../ ?
> Done, thanks.
I think you need to correct the paths inside compiling.slide too. E.g.:
.code compiling/rtype1.go /1 START OMIT/,/1 END OMIT/
Issue 117720043: code review 117720043: go.talks: add 2014/compiling talk from Google I/O
(Closed)
Created 9 years, 8 months ago by iant
Modified 9 years, 8 months ago
Reviewers: aram, campoy
Base URL:
Comments: 0