Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(103)

Issue 117720043: code review 117720043: go.talks: add 2014/compiling talk from Google I/O (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 8 months ago by iant
Modified:
9 years, 8 months ago
Reviewers:
aram, campoy, adg, dfc
CC:
golang-codereviews, dfc, kortschak, tux21b, adg
Visibility:
Public.

Description

go.talks: add 2014/compiling talk from Google I/O

Patch Set 1 #

Patch Set 2 : diff -r c636a8a8316f https://code.google.com/p/go.talks #

Patch Set 3 : diff -r c636a8a8316f https://code.google.com/p/go.talks #

Patch Set 4 : diff -r c636a8a8316f https://code.google.com/p/go.talks #

Patch Set 5 : diff -r c636a8a8316f https://code.google.com/p/go.talks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+371 lines, -0 lines) Patch
A 2014/compiling.slide View 1 2 1 chunk +145 lines, -0 lines 0 comments Download
A 2014/compiling/const1.go View 1 1 chunk +20 lines, -0 lines 0 comments Download
A 2014/compiling/const2.go View 1 1 chunk +20 lines, -0 lines 0 comments Download
A 2014/compiling/const3.go View 1 1 chunk +19 lines, -0 lines 0 comments Download
A 2014/compiling/name1.go View 1 1 chunk +23 lines, -0 lines 0 comments Download
A 2014/compiling/name2.go View 1 1 chunk +23 lines, -0 lines 0 comments Download
A 2014/compiling/rtype1.go View 1 1 chunk +60 lines, -0 lines 0 comments Download
A 2014/compiling/rtype2.go View 1 1 chunk +40 lines, -0 lines 0 comments Download
A 2014/compiling/var1.go View 1 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 13
iant
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.talks
9 years, 8 months ago (2014-07-12 00:06:11 UTC) #1
dfc
LGTM. I'm sorry I didn't get to see your talk in person.
9 years, 8 months ago (2014-07-12 05:43:06 UTC) #2
dfc
Oh, you may need to add // +build none to all your examples to avoid ...
9 years, 8 months ago (2014-07-12 06:35:44 UTC) #3
kortschak
mv compiling.slide ../ ?
9 years, 8 months ago (2014-07-12 08:54:34 UTC) #4
iant
On 2014/07/12 06:35:44, dfc wrote: > Oh, you may need to add // +build none ...
9 years, 8 months ago (2014-07-12 14:52:09 UTC) #5
iant
On 2014/07/12 08:54:34, kortschak wrote: > mv compiling.slide ../ ? Done, thanks. Ian
9 years, 8 months ago (2014-07-12 14:52:25 UTC) #6
tux21b
On 2014/07/12 14:52:25, iant wrote: > On 2014/07/12 08:54:34, kortschak wrote: > > mv compiling.slide ...
9 years, 8 months ago (2014-07-12 22:02:56 UTC) #7
adg
LGTM
9 years, 8 months ago (2014-07-14 06:10:31 UTC) #8
iant
*** Submitted as https://code.google.com/p/go/source/detail?r=f10112195b13&repo=talks *** go.talks: add 2014/compiling talk from Google I/O LGTM=dave, adg R=golang-codereviews, ...
9 years, 8 months ago (2014-07-14 15:30:18 UTC) #9
aram
I can't see this yet on talks.golang.org or tip.talks.golang.org. Is the process that puts it ...
9 years, 8 months ago (2014-07-15 21:21:19 UTC) #10
adg
Manual On Wednesday, 16 July 2014, <aram@mgk.ro> wrote: > I can't see this yet on ...
9 years, 8 months ago (2014-07-15 21:52:05 UTC) #11
aram
Thanks.
9 years, 8 months ago (2014-07-15 21:52:35 UTC) #12
campoy
9 years, 8 months ago (2014-07-15 22:07:04 UTC) #13
Message was sent while issue was closed.
On 2014/07/15 21:52:35, aram wrote:
> Thanks.

They're now available http://talks.golang.org/2014/compiling.slide#1
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b