Issue 11769043: code review 11769043: runtime: only define SEH when we need it.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11769043: code review 11769043: runtime: only define SEH when we need it. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by khr

Modified:
11 years, 8 months ago

Reviewers:
rsc, iant

CC:
golang-dev, iant

Visibility:
Public.

Description

runtime: only define SEH when we need it.

Patch Set 1 #

Patch Set 2 : diff -r bb75d03e6ccb https://khr%40golang.org@code.google.com/p/go/ #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
		src/pkg/runtime/proc.c	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

khr

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://khr%40golang.org@code.google.com/p/go/

11 years, 8 months ago (2013-07-24 16:38:04 UTC) #1

khr

On 2013/07/24 16:38:04, khr wrote: > Hello mailto:golang-dev@googlegroups.com, > > I'd like you to review ...

11 years, 8 months ago (2013-07-24 16:39:54 UTC) #2

iant

LGTM Though I wonder why the assignment to m->seh needs to be protected by #ifdef.

11 years, 8 months ago (2013-07-24 16:59:03 UTC) #4

khr

*** Submitted as https://code.google.com/p/go/source/detail?r=70477805c5f3 *** runtime: only define SEH when we need it. R=golang-dev, iant ...

11 years, 8 months ago (2013-07-24 16:59:49 UTC) #5

rsc

11 years, 8 months ago (2013-07-24 17:14:13 UTC) #6

I apologize for the #ifdefs, but it makes it very clear exactly which
systems it is for (just windows/386). I wasted an hour or more the other
day trying to find a place to put the SEH on amd64 during a cgo call on a
non-Go thread, only to discover that it's unneeded there.

Russ

Expand All Messages | Collapse All Messages