code review 11759044: runtime: drop EV_RECEIPT support from network pollster ...

runtime: drop EV_RECEIPT support from network pollster on kqueue

Currently Darwin and FreeBSD support and NetBSD and OpenBSD do not
support EV_RECEIPT flag. We will drop use of EV_RECEIPT for now.

Also enables to build runtime-integrated network pollster on
freebsd/amd64,386 and openbsd/amd64,386. It just does build but never
runs pollster stuff.

This is in preparation for runtime-integrated network pollster for BSD
variants.

Update issue 5199

[mikio, 2013-07-24 09:04:50]

Hello dvyukov@google.com, minux.ma@gmail.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[dvyukov, 2013-07-24 09:17:23]

Do I understand it correctly that darwin reports errors with EV_RECEIPT and bsd
systems with return code from kevent()? Or on bsd systems errors on individual
entries are silently discarded? Or darwin also reports with return code from
kevent()?
Can we just remove EV_RECEIPT from darwin as well?

[mikio, 2013-07-24 10:05:00]

On Wed, Jul 24, 2013 at 6:17 PM,  <dvyukov@google.com> wrote:

> Do I understand it correctly that darwin reports errors with EV_RECEIPT
> and bsd systems with return code from kevent()? Or on bsd systems errors
> on individual entries are silently discarded? Or darwin also reports
> with return code from kevent()?

If the platform does not support EV-RECEIPT,
https://github.com/freebsd/freebsd-head/blob/master/sys/kern/kern_event.c#L849
other errors in structured multiple descriptors will be silently
discarded, hooray!

> Can we just remove EV_RECEIPT from darwin as well?

Sure, for now we have no bulk update mech., it does make sense.

[mikio, 2013-07-24 15:07:37]

Hello dvyukov@google.com, minux.ma@gmail.com (cc: golang-dev@googlegroups.com),

Please take another look.

[dvyukov, 2013-07-24 15:17:43]

LGTM

[mikio, 2013-07-24 15:26:02]

*** Submitted as https://code.google.com/p/go/source/detail?r=acc121ea2d70 ***

runtime: drop EV_RECEIPT support from network pollster on kqueue

Currently Darwin and FreeBSD support and NetBSD and OpenBSD do not
support EV_RECEIPT flag. We will drop use of EV_RECEIPT for now.

Also enables to build runtime-integrated network pollster on
freebsd/amd64,386 and openbsd/amd64,386. It just does build but never
runs pollster stuff.

This is in preparation for runtime-integrated network pollster for BSD
variants.

Update issue 5199

R=dvyukov, minux.ma
CC=golang-dev
https://codereview.appspot.com/11759044