code review 117530044: userip: support IPv6 host/port.

go.blog/context: userip support for IPv6 host/port.

Makes example usable on IPv6 systems eg where localhost is ::1.

Fixes issue 8486.

[pnasrat, 2014-08-04 15:32:58]

Hello golang-codereviews@googlegroups.com (cc: sameer@golang.org),

I'd like you to review this change to
https://code.google.com/p/go.blog

[dave_cheney.net, 2014-08-05 02:03:00]

On 2014/08/04 15:32:58, pnasrat wrote:
> Hello mailto:golang-codereviews@googlegroups.com (cc:
mailto:sameer@golang.org),
> 
> I'd like you to review this change to
> https://code.google.com/p/go.blog

Thank you. Please update the description to reference the issue this cl fixes
and add a test.

[pnasrat, 2014-08-05 14:24:56]

On 2014/08/05 02:03:00, dfc wrote:
> On 2014/08/04 15:32:58, pnasrat wrote:
> > Hello mailto:golang-codereviews@googlegroups.com (cc:
> mailto:sameer@golang.org),
> > 
> > I'd like you to review this change to
> > https://code.google.com/p/go.blog
> 
> Thank you. Please update the description to reference the issue this cl fixes
> and add a test.

I can file a separate issue but this is just a change to make the blog example
more robust on different systems.

Do the same requirements for tests exist in the blog sub repo - I'm happy to add
some but none exist under code.google.com/p/go.blog/content/context currently

I just wanted to clarify before I start writing tests.

Paul

[pnasrat, 2014-08-06 19:08:35]

On 2014/08/05 14:24:56, pnasrat wrote:
> On 2014/08/05 02:03:00, dfc wrote:
> > On 2014/08/04 15:32:58, pnasrat wrote:
> > > Hello mailto:golang-codereviews@googlegroups.com (cc:
> > mailto:sameer@golang.org),
> > > 
> > > I'd like you to review this change to
> > > https://code.google.com/p/go.blog
> > 
> > Thank you. Please update the description to reference the issue this cl
fixes
> > and add a test.
> 
> I can file a separate issue but this is just a change to make the blog example
> more robust on different systems.

Filed issue and updated description and set fixes.

 
> Do the same requirements for tests exist in the blog sub repo - I'm happy to
add
> some but none exist under code.google.com/p/go.blog/content/context currently
> 
> I just wanted to clarify before I start writing tests.

Still waiting for feedback if go.blog requires tests

Paul

[adg, 2014-08-07 01:07:38]

LGTM
No, don't write a test.

[adg, 2014-08-07 01:22:22]

*** Submitted as
https://code.google.com/p/go/source/detail?r=3ede82aea9fd&repo=blog ***

go.blog/context: userip support for IPv6 host/port.

Makes example usable on IPv6 systems eg where localhost is ::1.

Fixes issue 8486.

LGTM=adg
R=golang-codereviews, dave, adg
CC=golang-codereviews, sameer
https://codereview.appspot.com/117530044

Committer: Andrew Gerrand <adg@golang.org>