code review 117430043: compress/{gzip,zlib}: mention that Close flushes

compress/{gzip,zlib}: mention that Close flushes

Our other CloseFlushers (archive/tar, compress/flate) do mention this.

[adg, 2014-08-01 00:50:03]

Hello r (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[dave_cheney.net, 2014-08-01 00:51:26]

LGTM.

On Fri, Aug 1, 2014 at 10:50 AM,  <adg@golang.org> wrote:
> Reviewers: r,
>
> Message:
> Hello r (cc: golang-codereviews@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> compress/{gzip,zlib}: mention that Close flushes
>
> Our other CloseFlushers (archive/tar, compress/flate) do mention this.
>
> Please review this at https://codereview.appspot.com/117430043/
>
> Affected files (+4, -2 lines):
>   M src/pkg/compress/gzip/gzip.go
>   M src/pkg/compress/zlib/writer.go
>
>
> Index: src/pkg/compress/gzip/gzip.go
> ===================================================================
> --- a/src/pkg/compress/gzip/gzip.go
> +++ b/src/pkg/compress/gzip/gzip.go
> @@ -245,7 +245,8 @@
>         return z.err
>  }
>
> -// Close closes the Writer. It does not close the underlying io.Writer.
> +// Close closes the Writer, flushing any unwritten data to the underlying
> +// io.Writer, but does not close the underlying io.Writer.
>  func (z *Writer) Close() error {
>         if z.err != nil {
>                 return z.err
> Index: src/pkg/compress/zlib/writer.go
> ===================================================================
> --- a/src/pkg/compress/zlib/writer.go
> +++ b/src/pkg/compress/zlib/writer.go
> @@ -174,7 +174,8 @@
>         return z.err
>  }
>
> -// Calling Close does not close the wrapped io.Writer originally passed to
> NewWriter.
> +// Close closes the Writer, flushing any unwritten data to the underlying
> +// io.Writer, but does not close the underlying io.Writer.
>  func (z *Writer) Close() error {
>         if !z.wroteHeader {
>                 z.err = z.writeHeader()
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

[r, 2014-08-01 01:51:58]

LGTM

[adg, 2014-08-01 01:54:19]

*** Submitted as https://code.google.com/p/go/source/detail?r=068a94c8700a ***

compress/{gzip,zlib}: mention that Close flushes

Our other CloseFlushers (archive/tar, compress/flate) do mention this.

LGTM=dave, r
R=r, dave
CC=golang-codereviews
https://codereview.appspot.com/117430043

[gobot, 2014-08-01 02:21:04]

This CL appears to have broken the openbsd-386-rootbsd builder.
See http://build.golang.org/log/1a467770503ea5ed210225c9719e9fca3831dab4