Issue 117250045: code review 117250045: go-tour: use ctrl-enter to fmt, not shift-space

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 117250045: code review 117250045: go-tour: use ctrl-enter to fmt, not shift-space (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 9 months ago by adg

Modified:
9 years, 9 months ago

Reviewers:
campoy

CC:
campoy, golang-codereviews

Visibility:
Public.

Description

go-tour: use ctrl-enter to fmt, not shift-space Apparently I type shift-space a lot when I type, so this new shortcut key gets in my way. I suppose I'm not the only one.

Patch Set 1 #

Patch Set 2 : diff -r be09df761bb0 https://code.google.com/p/go-tour #

Patch Set 3 : diff -r be09df761bb0 https://code.google.com/p/go-tour #

Patch Set 4 : diff -r be09df761bb0 https://code.google.com/p/go-tour #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	content/welcome.article	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	static/js/values.js	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

adg

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go-tour

9 years, 9 months ago (2014-07-29 01:11:59 UTC) #1

adg

Hello campoy, golang-codereviews@googlegroups.com (cc: golang-codereviews@googlegroups.com), Please take another look.

9 years, 9 months ago (2014-07-29 01:12:09 UTC) #2

campoy

On 2014/07/29 01:12:09, adg wrote: > Hello campoy, mailto:golang-codereviews@googlegroups.com (cc: > mailto:golang-codereviews@googlegroups.com), > > Please ...

9 years, 9 months ago (2014-07-29 21:21:42 UTC) #3

adg

Hello campoy@google.com, golang-codereviews@googlegroups.com (cc: golang-codereviews@googlegroups.com), Please take another look.

9 years, 9 months ago (2014-07-29 21:49:59 UTC) #4

campoy

On 2014/07/29 21:49:59, adg wrote: > Hello mailto:campoy@google.com, mailto:golang-codereviews@googlegroups.com (cc: > mailto:golang-codereviews@googlegroups.com), > > Please ...

9 years, 9 months ago (2014-07-29 22:01:51 UTC) #5

adg

9 years, 9 months ago (2014-07-29 22:02:41 UTC) #6

*** Submitted as https://code.google.com/p/go-tour/source/detail?r=9e407855c14d
***

go-tour: use ctrl-enter to fmt, not shift-space

Apparently I type shift-space a lot when I type,
so this new shortcut key gets in my way.
I suppose I'm not the only one.

LGTM=campoy
R=campoy, golang-codereviews
CC=golang-codereviews
https://codereview.appspot.com/117250045

Expand All Messages | Collapse All Messages