Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1245)

Issue 1171041: code review 1171041: go spec: simplify section on channel types (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 10 months ago by gri
Modified:
14 years, 10 months ago
Reviewers:
CC:
rsc, iant, r, golang-dev
Visibility:
Public.

Description

go spec: simplify section on channel types

Patch Set 1 #

Patch Set 2 : code review 1171041: go spec: simplify section on channel types #

Patch Set 3 : code review 1171041: go spec: simplify section on channel types #

Total comments: 2

Patch Set 4 : code review 1171041: go spec: simplify section on channel types #

Patch Set 5 : code review 1171041: go spec: simplify section on channel types #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -25 lines) Patch
M doc/go_spec.html View 1 2 3 4 3 chunks +23 lines, -25 lines 0 comments Download

Messages

Total messages: 6
gri
Hello rsc, iant, r (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 10 months ago (2010-05-07 23:26:15 UTC) #1
r
LGTM but get more reviews http://codereview.appspot.com/1171041/diff/5001/6001 File doc/go_spec.html (right): http://codereview.appspot.com/1171041/diff/5001/6001#newcode1164 doc/go_spec.html:1164: A channel may be ...
14 years, 10 months ago (2010-05-07 23:29:34 UTC) #2
rsc1
LGTM http://codereview.appspot.com/1171041/diff/5001/6001 File doc/go_spec.html (right): http://codereview.appspot.com/1171041/diff/5001/6001#newcode1175 doc/go_spec.html:1175: The <code>&lt;-</code> operator associates with the left-most <code>chan</code> ...
14 years, 10 months ago (2010-05-07 23:52:17 UTC) #3
iant
LGTM This exactly matches what gccgo's recursive descent parser does.
14 years, 10 months ago (2010-05-08 01:11:49 UTC) #4
gri
On Fri, May 7, 2010 at 6:11 PM, <iant@golang.org> wrote: > LGTM > > This ...
14 years, 10 months ago (2010-05-08 01:21:05 UTC) #5
gri
14 years, 10 months ago (2010-05-08 01:22:52 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=b089553088b4 ***

go spec: simplify section on channel types

R=rsc, iant, r
CC=golang-dev
http://codereview.appspot.com/1171041
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b