Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(77)

Issue 117040043: code review 117040043: runtime: keep build version around in binaries (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 8 months ago by khr
Modified:
9 years, 8 months ago
Reviewers:
minux, rsc
CC:
golang-codereviews, minux, khr1, rsc, dfc
Visibility:
Public.

Description

runtime: keep build version around in binaries So we can tell from a binary which version of Go built it.

Patch Set 1 #

Patch Set 2 : diff -r dd3851554f5b https://code.google.com/p/go/ #

Patch Set 3 : diff -r dd3851554f5b https://code.google.com/p/go/ #

Patch Set 4 : diff -r dd3851554f5b https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M src/cmd/dist/buildruntime.c View 1 chunk +2 lines, -1 line 0 comments Download
M src/pkg/runtime/proc.c View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 8
khr
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
9 years, 8 months ago (2014-07-22 03:20:44 UTC) #1
minux
Why do we need such a feature?
9 years, 8 months ago (2014-07-22 03:23:03 UTC) #2
khr1
I ran into this when someone sent me a binary that was failing and I ...
9 years, 8 months ago (2014-07-22 03:28:01 UTC) #3
minux
On Mon, Jul 21, 2014 at 11:28 PM, Keith Randall <khr@google.com> wrote: > I ran ...
9 years, 8 months ago (2014-07-22 03:31:12 UTC) #4
rsc
LGTM
9 years, 8 months ago (2014-07-22 03:38:13 UTC) #5
rsc
And for the record, for anyone who finds this CL and thinks otherwise, the door ...
9 years, 8 months ago (2014-07-22 03:38:31 UTC) #6
dfc
Noted. On 22 Jul 2014 15:38, "Russ Cox" <rsc@golang.org> wrote: > And for the record, ...
9 years, 8 months ago (2014-07-22 03:42:03 UTC) #7
khr
9 years, 8 months ago (2014-07-22 03:52:14 UTC) #8
*** Submitted as https://code.google.com/p/go/source/detail?r=448b8758d34f ***

runtime: keep build version around in binaries

So we can tell from a binary which version of
Go built it.

LGTM=minux, rsc
R=golang-codereviews, minux, khr, rsc, dave
CC=golang-codereviews
https://codereview.appspot.com/117040043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b