Issue 116720043: code review 116720043: cmd/ld: add go-specific dwarf type information

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 116720043: code review 116720043: cmd/ld: add go-specific dwarf type information (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by rsc

Modified:
10 years, 8 months ago

Reviewers:
r

CC:
r, golang-codereviews

Visibility:
Public.

Description

cmd/ld: add go-specific dwarf type information

Patch Set 2 : diff -r 36cc211b26b4 https://go.googlecode.com/hg #

Patch Set 3 : diff -r 36cc211b26b4 https://go.googlecode.com/hg #

Patch Set 4 : diff -r 36cc211b26b4 https://go.googlecode.com/hg #

Patch Set 5 : diff -r 59c67dc02832 https://go.googlecode.com/hg #

Total comments: 1

Patch Set 6 : diff -r 59c67dc02832 https://code.google.com/p/go/ #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -46 lines)			Patch
	M	src/cmd/ld/dwarf.c	View	1 2 3 4 5	27 chunks	+64 lines, -46 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg

10 years, 8 months ago (2014-07-11 22:12:37 UTC) #1

LGTM https://codereview.appspot.com/116720043/diff/70001/src/cmd/ld/dwarf.c File src/cmd/ld/dwarf.c (right): https://codereview.appspot.com/116720043/diff/70001/src/cmd/ld/dwarf.c#newcode151 src/cmd/ld/dwarf.c:151: // Fake attributes for slices, maps and channel ...

10 years, 8 months ago (2014-07-11 22:15:24 UTC) #2

rsc

10 years, 8 months ago (2014-07-12 03:10:06 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=4f11acb18404 ***

cmd/ld: add go-specific dwarf type information

LGTM=r
R=r
CC=golang-codereviews
https://codereview.appspot.com/116720043

Expand All Messages | Collapse All Messages