code review 1166041: compress: renamings.

compress: renamings.
NewDeflater -> NewWriter
NewInflater -> NewReader
Deflater -> Compressor
Inflater -> Decompressor

[r, 2010-05-07 21:21:56]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc1, 2010-05-07 21:24:29]

LGTM

[r, 2010-05-07 21:32:36]

*** Submitted as http://code.google.com/p/go/source/detail?r=5190b0c2de56 ***

compress: renamings.
NewDeflater -> NewWriter
NewInflater -> NewReader
Deflater -> Compressor
Inflater -> Decompressor

R=rsc
CC=golang-dev
http://codereview.appspot.com/1166041

[cw, 2010-05-08 06:30:39]

A little too late...

This is confusing still.

NewWriter ... is that something that writes a compressed stream from an
uncompressed stream or the reverse?  At least NewDeflator seemed clearer.

Why not NewCompressor?

[r2, 2010-05-08 13:39:23]

On May 7, 2010, at 11:30 PM, cw@f00f.org wrote:

> A little too late...
> 
> This is confusing still.
> 
> NewWriter ... is that something that writes a compressed stream from an
> uncompressed stream or the reverse?  At least NewDeflator seemed
> clearer.
> 
> Why not NewCompressor?

Because you get a Writer back.  It's not confusing if you think of it from the
client's view:  gzip.NewWriter writes a gzip; gzip.NewReader reads one.   If you
want to compress data into a gzip, that's a write; if you want to decompress,
that's a read.  It doesn't make much sense to write an uncompressed stream from
a compressed one.

-rob