LGTM. On Thu, Jul 31, 2014 at 5:16 PM, <adg@golang.org> wrote: > Reviewers: r, > ...
9 years, 9 months ago
(2014-07-31 07:55:38 UTC)
#2
LGTM.
On Thu, Jul 31, 2014 at 5:16 PM, <adg@golang.org> wrote:
> Reviewers: r,
>
> Message:
> Hello r (cc: golang-codereviews@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go.blog
>
>
> Description:
> go.blog: fix error in Laws of Reflection article
>
> Please review this at https://codereview.appspot.com/116440043/
>
> Affected files (+1, -1 lines):
> M content/laws-of-reflection.article
>
>
> Index: content/laws-of-reflection.article
> ===================================================================
> --- a/content/laws-of-reflection.article
> +++ b/content/laws-of-reflection.article
> @@ -80,7 +80,7 @@
> var empty interface{}
> empty = w
>
> -and our empty interface value `e` will again contain that same pair,
> (`tty`, `*os.File`). That's handy: an empty interface can hold any value
> and contains all the information we could ever need about that value.
> +and our empty interface value `empty` will again contain that same pair,
> (`tty`, `*os.File`). That's handy: an empty interface can hold any value
> and contains all the information we could ever need about that value.
>
> (We don't need a type assertion here because it's known statically that
> `w` satisfies the empty interface. In the example where we moved a value
> from a `Reader` to a `Writer`, we needed to be explicit and use a type
> assertion because `Writer`'s methods are not a subset of `Reader`'s.)
>
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
Issue 116440043: code review 116440043: go.blog: fix error in Laws of Reflection article
(Closed)
Created 9 years, 9 months ago by adg
Modified 9 years, 9 months ago
Reviewers:
Base URL:
Comments: 0