Issue 116430044: code review 116430044: context: provide String methods. The Strings show the ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 116430044: code review 116430044: context: provide String methods. The Strings show the ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by Sameer Ajmani

Modified:
10 years, 7 months ago

Reviewers:
bcmills

CC:
bcmills, golang-codereviews

Visibility:
Public.

Description

context: provide String methods. The Strings show the functions called to construct the context left-to-right. External implementations of the Context interface may break the chain, but establishing this pattern now may encourage them to do the right thing.

Patch Set 1 #

Patch Set 2 : diff -r 0075ecfeb3d8 https://code.google.com/p/go.net #

Patch Set 3 : diff -r 0075ecfeb3d8 https://code.google.com/p/go.net #

Patch Set 4 : diff -r 0075ecfeb3d8 https://code.google.com/p/go.net #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -10 lines)			Patch
	M	context/context.go	View		4 chunks	+13 lines, -0 lines	0 comments	Download
	M	context/context_test.go	View		10 chunks	+27 lines, -10 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Sameer Ajmani

Hello bcmills (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.net

10 years, 7 months ago (2014-07-30 18:53:36 UTC) #1

Sameer Ajmani

10 years, 7 months ago (2014-08-01 13:28:44 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=6a58d15273e1&repo=net ***

context: provide String methods.  The Strings show the functions called
to construct the context left-to-right.  External implementations of the
Context interface may break the chain, but establishing this pattern now
may encourage them to do the right thing.

LGTM=bcmills
R=bcmills
CC=golang-codereviews
https://codereview.appspot.com/116430044

Expand All Messages | Collapse All Messages