Issue 116420045: code review 116420045: context: fix small leak introduced by reordering.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 116420045: code review 116420045: context: fix small leak introduced by reordering. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by Sameer Ajmani

Modified:
10 years, 8 months ago

Reviewers:
bcmills

CC:
bcmills, golang-codereviews

Visibility:
Public.

Description

context: fix small leak introduced by reordering.

Patch Set 1 #

Patch Set 2 : diff -r 0790d591105b https://code.google.com/p/go.net #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	context/context.go	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Sameer Ajmani

Hello bcmills@google.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.net

10 years, 8 months ago (2014-07-30 16:34:18 UTC) #1

Sameer Ajmani

10 years, 8 months ago (2014-07-30 17:03:34 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=0075ecfeb3d8&repo=net ***

context: fix small leak introduced by reordering.

LGTM=bcmills
R=bcmills
CC=golang-codereviews
https://codereview.appspot.com/116420045

Expand All Messages | Collapse All Messages