code review 116350043: go.talks: add "// +build ignore,OMIT" to all example...

go.talks: add "// +build ignore,OMIT" to all example Go source files

[minux, 2014-07-26 23:33:30]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go.talks

[brainman, 2014-07-26 23:40:13]

LGTM

[adg, 2014-07-28 04:18:29]

LGTM

The standard in this repo is just "+build OMIT", if you can be bothered
changing it.




On 27 July 2014 09:33, <minux@golang.org> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go.talks
>
>
> Description:
> go.talks: adding "// +build ignore,OMIT" to all example Go source files.
>
> Please review this at https://codereview.appspot.com/116350043/
>
> Affected files (+44, -0 lines):
>   M 2014/go4java/battle.go
>   M 2014/go4java/chan.go
>   M 2014/go4java/conc1.go
>   M 2014/go4java/conc2.go
>   M 2014/go4java/conc3.go
>   M 2014/go4java/embedsample.go
>   M 2014/go4java/goodcounter.go
>   M 2014/go4java/goroutines.go
>   M 2014/go4java/loopback.go
>   M 2014/go4java/writecounter.go
>   M 2014/playground/deadlock.go
>   M 2014/playground/file.go
>   M 2014/playground/heap.go
>   M 2014/playground/hello.go
>   M 2014/playground/http.go
>   M 2014/playground/loop.go
>   M 2014/playground/net.go
>   M 2014/playground/removeall.go
>   M 2014/playground/rm.go
>   M 2014/playground/sleep.go
>   M 2014/playground/sleepfast.go
>   M 2014/playground/stack.go
>
>
> Index: 2014/go4java/battle.go
> ===================================================================
> --- a/2014/go4java/battle.go
> +++ b/2014/go4java/battle.go
> @@ -1,3 +1,5 @@
> +// +build ignore,OMIT
> +
>  package main
>
>  import (
> Index: 2014/go4java/chan.go
> ===================================================================
> --- a/2014/go4java/chan.go
> +++ b/2014/go4java/chan.go
> @@ -1,3 +1,5 @@
> +// +build ignore,OMIT
> +
>  package main
>
>  import (
> Index: 2014/go4java/conc1.go
> ===================================================================
> --- a/2014/go4java/conc1.go
> +++ b/2014/go4java/conc1.go
> @@ -1,3 +1,5 @@
> +// +build ignore,OMIT
> +
>  package main
>
>  import (
> Index: 2014/go4java/conc2.go
> ===================================================================
> --- a/2014/go4java/conc2.go
> +++ b/2014/go4java/conc2.go
> @@ -1,3 +1,5 @@
> +// +build ignore,OMIT
> +
>  package main
>
>  import (
> Index: 2014/go4java/conc3.go
> ===================================================================
> --- a/2014/go4java/conc3.go
> +++ b/2014/go4java/conc3.go
> @@ -1,3 +1,5 @@
> +// +build ignore,OMIT
> +
>  package main
>
>  import (
> Index: 2014/go4java/embedsample.go
> ===================================================================
> --- a/2014/go4java/embedsample.go
> +++ b/2014/go4java/embedsample.go
> @@ -1,3 +1,5 @@
> +// +build ignore,OMIT
> +
>  package main
>
>  import "fmt"
> Index: 2014/go4java/goodcounter.go
> ===================================================================
> --- a/2014/go4java/goodcounter.go
> +++ b/2014/go4java/goodcounter.go
> @@ -1,3 +1,5 @@
> +// +build ignore,OMIT
> +
>  package main
>
>  import (
> Index: 2014/go4java/goroutines.go
> ===================================================================
> --- a/2014/go4java/goroutines.go
> +++ b/2014/go4java/goroutines.go
> @@ -1,3 +1,5 @@
> +// +build ignore,OMIT
> +
>  package main
>
>  import (
> Index: 2014/go4java/loopback.go
> ===================================================================
> --- a/2014/go4java/loopback.go
> +++ b/2014/go4java/loopback.go
> @@ -1,3 +1,5 @@
> +// +build ignore,OMIT
> +
>  package main
>
>  import (
> Index: 2014/go4java/writecounter.go
> ===================================================================
> --- a/2014/go4java/writecounter.go
> +++ b/2014/go4java/writecounter.go
> @@ -1,3 +1,5 @@
> +// +build ignore,OMIT
> +
>  package main
>
>  import (
> Index: 2014/playground/deadlock.go
> ===================================================================
> --- a/2014/playground/deadlock.go
> +++ b/2014/playground/deadlock.go
> @@ -1,3 +1,5 @@
> +// +build ignore,OMIT
> +
>  package main
>
>  func main() {
> Index: 2014/playground/file.go
> ===================================================================
> --- a/2014/playground/file.go
> +++ b/2014/playground/file.go
> @@ -1,3 +1,5 @@
> +// +build ignore,OMIT
> +
>  package main
>
>  import (
> Index: 2014/playground/heap.go
> ===================================================================
> --- a/2014/playground/heap.go
> +++ b/2014/playground/heap.go
> @@ -1,3 +1,5 @@
> +// +build ignore,OMIT
> +
>  package main
>
>  type list struct {
> Index: 2014/playground/hello.go
> ===================================================================
> --- a/2014/playground/hello.go
> +++ b/2014/playground/hello.go
> @@ -1,3 +1,5 @@
> +// +build ignore,OMIT
> +
>  package main
>
>  import "fmt"
> Index: 2014/playground/http.go
> ===================================================================
> --- a/2014/playground/http.go
> +++ b/2014/playground/http.go
> @@ -1,3 +1,5 @@
> +// +build ignore,OMIT
> +
>  package main
>
>  import (
> Index: 2014/playground/loop.go
> ===================================================================
> --- a/2014/playground/loop.go
> +++ b/2014/playground/loop.go
> @@ -1,3 +1,5 @@
> +// +build ignore,OMIT
> +
>  package main
>
>  func main() {
> Index: 2014/playground/net.go
> ===================================================================
> --- a/2014/playground/net.go
> +++ b/2014/playground/net.go
> @@ -1,3 +1,5 @@
> +// +build ignore,OMIT
> +
>  package main
>
>  import (
> Index: 2014/playground/removeall.go
> ===================================================================
> --- a/2014/playground/removeall.go
> +++ b/2014/playground/removeall.go
> @@ -1,3 +1,5 @@
> +// +build ignore,OMIT
> +
>  package main
>
>  import (
> Index: 2014/playground/rm.go
> ===================================================================
> --- a/2014/playground/rm.go
> +++ b/2014/playground/rm.go
> @@ -1,3 +1,5 @@
> +// +build ignore,OMIT
> +
>  package main
>
>  import (
> Index: 2014/playground/sleep.go
> ===================================================================
> --- a/2014/playground/sleep.go
> +++ b/2014/playground/sleep.go
> @@ -1,3 +1,5 @@
> +// +build ignore,OMIT
> +
>  package main
>
>  import (
> Index: 2014/playground/sleepfast.go
> ===================================================================
> --- a/2014/playground/sleepfast.go
> +++ b/2014/playground/sleepfast.go
> @@ -1,3 +1,5 @@
> +// +build ignore,OMIT
> +
>  package main
>
>  import (
> Index: 2014/playground/stack.go
> ===================================================================
> --- a/2014/playground/stack.go
> +++ b/2014/playground/stack.go
> @@ -1,3 +1,5 @@
> +// +build ignore,OMIT
> +
>  package main
>
>  func foo(a [1000]byte) {
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[minux, 2014-07-28 04:57:45]

*** Submitted as
https://code.google.com/p/go/source/detail?r=7094cf573469&repo=talks ***

go.talks: add "// +build ignore,OMIT" to all example Go source files

LGTM=alex.brainman, adg
R=golang-codereviews, alex.brainman, adg
CC=golang-codereviews
https://codereview.appspot.com/116350043