Issue 116300044: code review 116300044: net/http: make ServeContent support dates in If-Range h...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 116300044: code review 116300044: net/http: make ServeContent support dates in If-Range h... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 9 months ago by bradfitz

Modified:
9 years, 9 months ago

Reviewers:
gobot, adg, dave

CC:
adg, golang-codereviews

Visibility:
Public.

Description

net/http: make ServeContent support dates in If-Range headers Fixes Issue 8367

Patch Set 1 #

Patch Set 2 : diff -r c8059ac4e0ec https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r fda4c0d14c53 https://go.googlecode.com/hg/ #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -8 lines)			Patch
	M	src/pkg/net/http/fs.go	View		3 chunks	+17 lines, -8 lines	0 comments	Download
	M	src/pkg/net/http/fs_test.go	View		1 chunk	+22 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bradfitz

Hello adg@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

9 years, 9 months ago (2014-07-25 20:07:56 UTC) #1

bradfitz

*** Submitted as https://code.google.com/p/go/source/detail?r=ba125b11fd2d *** net/http: make ServeContent support dates in If-Range headers Fixes Issue ...

9 years, 9 months ago (2014-07-28 06:30:56 UTC) #3

gobot

This CL appears to have broken the freebsd-amd64-race builder. See http://build.golang.org/log/edf9d0759be1fa3dd6c27e64e3cd8ed36eb84b28

9 years, 9 months ago (2014-07-28 06:40:56 UTC) #4

dave_cheney.net

9 years, 9 months ago (2014-07-28 06:42:13 UTC) #5

not really

ok  	runtime/debug	1.299s
--- FAIL: TestCPUProfileMultithreaded (25.67s)
	pprof_test.go:136: crc32.ChecksumIEEE: 0
	pprof_test.go:136: crc32.Update: 8
	pprof_test.go:150: crc32.ChecksumIEEE has 0 samples out of 8, want at
least 1, ideally 4
FAIL
FAIL	runtime/pprof	62.597s



On Mon, Jul 28, 2014 at 4:40 PM, <gobot@golang.org> wrote:

> This CL appears to have broken the freebsd-amd64-race builder.
> See http://build.golang.org/log/edf9d0759be1fa3dd6c27e64e3cd8ed36eb84b28
>
>
> https://codereview.appspot.com/116300044/
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

Expand All Messages | Collapse All Messages