Issue 116290043: code review 116290043: runtime/pprof: fix data race

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 116290043: code review 116290043: runtime/pprof: fix data race (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 10 months ago by dvyukov

Modified:
9 years, 9 months ago

Reviewers:
bradfitz

CC:
golang-codereviews, bradfitz

Visibility:
Public.

Description

runtime/pprof: fix data race It's unclear why we do this broken double-checked locking. The mutex is not held for the whole duration of CPU profiling. Fixes issue 8365.

Patch Set 1 #

Patch Set 2 : diff -r b6a42b0aeef6 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r b6a42b0aeef6 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r e0bf1fc9dd8ed6029e45c9941d3f8dcce5ac9c8e https://dvyukov%40google.com@code.google.com/p/go/ #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -6 lines)			Patch
	M	src/pkg/runtime/pprof/pprof.go	View	1	1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dvyukov

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/

9 years, 10 months ago (2014-07-25 11:47:02 UTC) #1

dvyukov

On 2014/07/25 11:47:02, dvyukov wrote: > Hello mailto:golang-codereviews@googlegroups.com, > > I'd like you to review ...

9 years, 9 months ago (2014-08-05 17:13:14 UTC) #2

dvyukov

9 years, 9 months ago (2014-08-12 21:02:09 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=5d9094d9b134 ***

runtime/pprof: fix data race
It's unclear why we do this broken double-checked locking.
The mutex is not held for the whole duration of CPU profiling.
Fixes issue 8365.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/116290043

Expand All Messages | Collapse All Messages