code review 11623043: libmach,lib9: override unused parameter warnings (fixes...

libmach,lib9: override unused parameter warnings (fixes netbsd and openbsd builds)

[brainman, 2013-07-20 03:16:02]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[brainman, 2013-07-20 03:16:49]

Not tested. But fix looks similar to windows.

Alex

[bradfitz, 2013-07-20 05:13:06]

LGTM



On Sat, Jul 20, 2013 at 1:16 PM, <alex.brainman@gmail.com> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> libmach,lib9: override unused parameter warnings (fixes netbsd and
> openbsd builds)
>
> Please review this at
https://codereview.appspot.**com/11623043/<https://codereview.appspot.com/116...
>
> Affected files:
>   M src/libmach/netbsd.c
>   M src/libmach/openbsd.c
>
>
> Index: src/libmach/netbsd.c
> ==============================**==============================**=======
> --- a/src/libmach/netbsd.c
> +++ b/src/libmach/netbsd.c
> @@ -7,6 +7,8 @@
>  int
>  ctlproc(int pid, char *msg)
>  {
> +       USED(pid);
> +       USED(msg);
>         sysfatal("ctlproc unimplemented in NetBSD");
>         return -1;
>  }
> @@ -14,6 +16,7 @@
>  char*
>  proctextfile(int pid)
>  {
> +       USED(pid);
>         sysfatal("proctextfile unimplemented in NetBSD");
>         return nil;
>  }
> @@ -21,6 +24,7 @@
>  char*
>  procstatus(int pid)
>  {
> +       USED(pid);
>         sysfatal("procstatus unimplemented in NetBSD");
>         return nil;
>  }
> @@ -28,6 +32,8 @@
>  Map*
>  attachproc(int pid, Fhdr *fp)
>  {
> +       USED(pid);
> +       USED(fp);
>         sysfatal("attachproc unimplemented in NetBSD");
>         return nil;
>  }
> @@ -35,12 +41,16 @@
>  void
>  detachproc(Map *m)
>  {
> +       USED(m);
>         sysfatal("detachproc unimplemented in NetBSD");
>  }
>
>  int
>  procthreadpids(int pid, int *p, int np)
>  {
> +       USED(pid);
> +       USED(p);
> +       USED(np);
>         sysfatal("procthreadpids unimplemented in NetBSD");
>         return -1;
>  }
> Index: src/libmach/openbsd.c
> ==============================**==============================**=======
> --- a/src/libmach/openbsd.c
> +++ b/src/libmach/openbsd.c
> @@ -7,6 +7,8 @@
>  int
>  ctlproc(int pid, char *msg)
>  {
> +       USED(pid);
> +       USED(msg);
>         sysfatal("ctlproc unimplemented in OpenBSD");
>         return -1;
>  }
> @@ -14,6 +16,7 @@
>  char*
>  proctextfile(int pid)
>  {
> +       USED(pid);
>         sysfatal("proctextfile unimplemented in OpenBSD");
>         return nil;
>  }
> @@ -21,6 +24,7 @@
>  char*
>  procstatus(int pid)
>  {
> +       USED(pid);
>         sysfatal("procstatus unimplemented in OpenBSD");
>         return nil;
>  }
> @@ -28,6 +32,8 @@
>  Map*
>  attachproc(int pid, Fhdr *fp)
>  {
> +       USED(pid);
> +       USED(fp);
>         sysfatal("attachproc unimplemented in OpenBSD");
>         return nil;
>  }
> @@ -35,12 +41,16 @@
>  void
>  detachproc(Map *m)
>  {
> +       USED(m);
>         sysfatal("detachproc unimplemented in OpenBSD");
>  }
>
>  int
>  procthreadpids(int pid, int *p, int np)
>  {
> +       USED(pid);
> +       USED(p);
> +       USED(np);
>         sysfatal("procthreadpids unimplemented in OpenBSD");
>         return -1;
>  }
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[brainman, 2013-07-20 06:09:37]

*** Submitted as https://code.google.com/p/go/source/detail?r=372ae572457a ***

libmach,lib9: override unused parameter warnings (fixes netbsd and openbsd
builds)

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/11623043