code review 11620044: libmach,lib9: override unused parameter warnings (fixes...

libmach,lib9: override unused parameter warnings (fixes windows build)

[brainman, 2013-07-20 02:18:07]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[dave_cheney.net, 2013-07-20 02:27:05]

LGTM. Thanks brainman. 

On 20/07/2013, at 12:18, alex.brainman@gmail.com wrote:

> Reviewers: golang-dev1,
> 
> Message:
> Hello golang-dev@googlegroups.com,
> 
> I'd like you to review this change to
> https://go.googlecode.com/hg/
> 
> 
> Description:
> libmach,lib9: override unused parameter warnings (fixes windows build)
> 
> Please review this at https://codereview.appspot.com/11620044/
> 
> Affected files:
>  M src/lib9/_p9dir.c
>  M src/lib9/dirfwstat.c
>  M src/lib9/windows.c
>  M src/libmach/windows.c
> 
> 
> Index: src/lib9/_p9dir.c
> ===================================================================
> --- a/src/lib9/_p9dir.c
> +++ b/src/lib9/_p9dir.c
> @@ -43,6 +43,9 @@
>    char tmp[20];
>    int sz, fd;
> 
> +#ifdef _WIN32
> +    USED(lst);
> +#endif
>    fd = -1;
>    USED(fd);
>    sz = 0;
> Index: src/lib9/dirfwstat.c
> ===================================================================
> --- a/src/lib9/dirfwstat.c
> +++ b/src/lib9/dirfwstat.c
> @@ -48,6 +48,8 @@
> static int
> futimes(int fd, struct timeval *tv)
> {
> +    USED(fd);
> +    USED(tv);
>    werrstr("futimes not available");
>    return -1;
> }
> Index: src/lib9/windows.c
> ===================================================================
> --- a/src/lib9/windows.c
> +++ b/src/lib9/windows.c
> @@ -14,6 +14,7 @@
> int
> p9rfork(int flags)
> {
> +    USED(flags);
>    return -1;
> }
> 
> Index: src/libmach/windows.c
> ===================================================================
> --- a/src/libmach/windows.c
> +++ b/src/libmach/windows.c
> @@ -7,6 +7,8 @@
> int
> ctlproc(int pid, char *msg)
> {
> +    USED(pid);
> +    USED(msg);
>    sysfatal("ctlproc unimplemented in Windows");
>    return -1;
> }
> @@ -14,6 +16,7 @@
> char*
> proctextfile(int pid)
> {
> +    USED(pid);
>    sysfatal("proctextfile unimplemented in Windows");
>    return nil;
> }
> @@ -21,6 +24,7 @@
> char*
> procstatus(int pid)
> {
> +    USED(pid);
>    sysfatal("procstatus unimplemented in Windows");
>    return nil;
> }
> @@ -28,6 +32,8 @@
> Map*
> attachproc(int pid, Fhdr *fp)
> {
> +    USED(pid);
> +    USED(fp);
>    sysfatal("attachproc unimplemented in Windows");
>    return nil;
> }
> @@ -35,12 +41,16 @@
> void
> detachproc(Map *m)
> {
> +    USED(m);
>    sysfatal("detachproc unimplemented in Windows");
> }
> 
> int
> procthreadpids(int pid, int *p, int np)
> {
> +    USED(pid);
> +    USED(p);
> +    USED(np);
>    sysfatal("procthreadpids unimplemented in Windows");
>    return -1;
> }
> @@ -59,6 +69,10 @@
> int
> pwrite(int fd, void *buf, int count, int offset)
> {
> +    USED(fd);
> +    USED(buf);
> +    USED(count);
> +    USED(offset);
>    sysfatal("pwrite unimplemented in Windows");
>    return -1;
> }
> @@ -66,6 +80,8 @@
> int
> nanosleep(const struct timespec *rqtp, struct timespec *rmtp)
> {
> +    USED(rqtp);
> +    USED(rmtp);
>    sysfatal("nanosleep unimplemented in Windows");
>    return -1;
> }
> 
> 
> -- 
> 
> ---You received this message because you are subscribed to the Google Groups
"golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
> 
> 

[brainman, 2013-07-20 02:43:57]

*** Submitted as https://code.google.com/p/go/source/detail?r=3aa62752e9a2 ***

libmach,lib9: override unused parameter warnings (fixes windows build)

R=golang-dev, dave
CC=golang-dev
https://codereview.appspot.com/11620044