Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(61)

Issue 116090043: code review 116090043: go-tour: add Type Inference and Zero Values slides (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 9 months ago by adg
Modified:
9 years, 9 months ago
Reviewers:
campoy
CC:
campoy, golang-codereviews
Visibility:
Public.

Description

go-tour: add Type Inference and Zero Values slides Also check off a couple of finished things from the TODO list.

Patch Set 1 #

Patch Set 2 : diff -r 91f9594fc692 https://code.google.com/p/go-tour #

Patch Set 3 : diff -r 04766421959a https://code.google.com/p/go-tour #

Patch Set 4 : diff -r 04766421959a https://code.google.com/p/go-tour #

Patch Set 5 : diff -r be09df761bb0 https://code.google.com/p/go-tour #

Total comments: 10

Patch Set 6 : diff -r 9e407855c14d https://code.google.com/p/go-tour #

Patch Set 7 : diff -r 9e407855c14d https://code.google.com/p/go-tour #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -3 lines) Patch
M TODO View 3 chunks +4 lines, -3 lines 0 comments Download
M content/basics.article View 2 chunks +31 lines, -0 lines 0 comments Download
A content/basics/type-inference.go View 1 chunk +8 lines, -0 lines 0 comments Download
A content/basics/zero.go View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 6
adg
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go-tour
9 years, 9 months ago (2014-07-22 04:44:40 UTC) #1
adg
Hello campoy, golang-codereviews@googlegroups.com (cc: golang-codereviews@googlegroups.com), Please take another look.
9 years, 9 months ago (2014-07-29 01:10:11 UTC) #2
campoy
PTAL https://codereview.appspot.com/116090043/diff/80001/content/basics.article File content/basics.article (right): https://codereview.appspot.com/116090043/diff/80001/content/basics.article#newcode150 content/basics.article:150: The zero value for numeric types is `0`. ...
9 years, 9 months ago (2014-07-29 22:15:10 UTC) #3
adg
PTAL https://codereview.appspot.com/116090043/diff/80001/content/basics.article File content/basics.article (right): https://codereview.appspot.com/116090043/diff/80001/content/basics.article#newcode150 content/basics.article:150: The zero value for numeric types is `0`. ...
9 years, 9 months ago (2014-07-29 23:14:13 UTC) #4
campoy
LGTM https://codereview.appspot.com/116090043/diff/80001/content/basics/zero.go File content/basics/zero.go (right): https://codereview.appspot.com/116090043/diff/80001/content/basics/zero.go#newcode10 content/basics/zero.go:10: fmt.Printf("%v %v %v %q", i, f, b, s) ...
9 years, 9 months ago (2014-07-30 00:43:10 UTC) #5
adg
9 years, 9 months ago (2014-07-30 00:48:46 UTC) #6
*** Submitted as https://code.google.com/p/go-tour/source/detail?r=0e09afd42b11
***

go-tour: add Type Inference and Zero Values slides

Also check off a couple of finished things from the TODO list.

LGTM=campoy
R=campoy, golang-codereviews
CC=golang-codereviews
https://codereview.appspot.com/116090043

https://codereview.appspot.com/116090043/diff/80001/content/basics/zero.go
File content/basics/zero.go (right):

https://codereview.appspot.com/116090043/diff/80001/content/basics/zero.go#ne...
content/basics/zero.go:10: fmt.Printf("%v %v %v %q", i, f, b, s)
On 2014/07/30 00:43:10, campoy wrote:
> On 2014/07/29 23:14:13, adg wrote:
> > On 2014/07/29 22:15:10, campoy wrote:
> > > fmt.Println(i, f, b, s)
> > 
> > Done, although I wanted to show the quoted string to prove it is an empty
> > string.
> 
> I didn't notice that, feel free to go back to printf

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b