Issue 11604043: code review 11604043: cmd/ld, runtime: remove unused fields from Func

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11604043: code review 11604043: cmd/ld, runtime: remove unused fields from Func (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by rsc

Modified:
11 years, 8 months ago

Reviewers:
r

CC:
golang-dev, r

Visibility:
Public.

Description

cmd/ld, runtime: remove unused fields from Func

Patch Set 1 #

Patch Set 2 : diff -r ea5c70726372 https://code.google.com/p/go/ #

Patch Set 3 : diff -r ea5c70726372 https://code.google.com/p/go/ #

Patch Set 4 : diff -r fe3232662436 https://code.google.com/p/go/ #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -24 lines)			Patch
M	src/cmd/ld/lib.c	View	1	3 chunks	+1 line, -8 lines	0 comments	Download
M	src/libmach/sym.c	View	1	4 chunks	+17 lines, -8 lines	0 comments	Download
M	src/pkg/debug/gosym/pclntab.go	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download
M	src/pkg/runtime/runtime.h	View	1	1 chunk	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

11 years, 8 months ago (2013-07-19 20:50:46 UTC) #1

rsc

11 years, 8 months ago (2013-07-19 22:52:38 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=9a6496d310ec ***

cmd/ld, runtime: remove unused fields from Func

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/11604043

Expand All Messages | Collapse All Messages