Issue 11595045: code review 11595045: runtime: fix windows build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11595045: code review 11595045: runtime: fix windows build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by rsc

Modified:
11 years, 8 months ago

Reviewers:
brainman

CC:
golang-dev

Visibility:
Public.

Description

runtime: fix windows build

Patch Set 1 #

Patch Set 2 : diff -r 1d8320d97ad0 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 0d0b4459ebd3 https://code.google.com/p/go/ #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/pkg/runtime/asm_386.s	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	src/pkg/runtime/asm_amd64.s	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 8 months ago (2013-07-24 02:59:28 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=fe3401660c1c *** runtime: fix windows build TBR=golang-dev CC=golang-dev https://codereview.appspot.com/11595045

11 years, 8 months ago (2013-07-24 02:59:36 UTC) #2

brainman

11 years, 8 months ago (2013-07-24 03:13:15 UTC) #3

Message was sent while issue was closed.

LGTM

It was stuck looping around in needm / lockextra doing usleep.

Alex

Expand All Messages | Collapse All Messages