code review 115860045: runtime: add throwgo

runtime: add throwgo

Fixes issue 8380.

Also update hashmap.go to use throwgo rather than panic.

[dave_cheney.net, 2014-07-18 00:35:34]

Hello khr@golang.org, rsc@golang.org (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[khr, 2014-07-18 01:07:13]

On 2014/07/18 00:35:34, dfc wrote:
> Hello mailto:khr@golang.org, mailto:rsc@golang.org (cc:
mailto:golang-codereviews@googlegroups.com),
> 
> I'd like you to review this change to
> https://code.google.com/p/go

You could put the throwgo declaration in stubs.go.
Otherwise, LGTM.

[dave_cheney.net, 2014-07-18 01:20:26]

> You could put the throwgo declaration in stubs.go.

That was the file I was looking for.

PTAL.

[khr1, 2014-07-18 06:26:22]

LGTM.


On Thu, Jul 17, 2014 at 6:20 PM, <dave@cheney.net> wrote:

> You could put the throwgo declaration in stubs.go.
>>
>
> That was the file I was looking for.
>
> PTAL.
>
>
> https://codereview.appspot.com/115860045/
>

[dave_cheney.net, 2014-07-18 06:30:56]

*** Submitted as https://code.google.com/p/go/source/detail?r=2facb9da08d5 ***

runtime: add throwgo

Fixes issue 8380.

Also update hashmap.go to use throwgo rather than panic.

LGTM=khr
R=khr, rsc
CC=golang-codereviews
https://codereview.appspot.com/115860045

[elias.naur, 2014-07-18 11:31:10]

On 2014/07/18 06:30:56, dfc wrote:
> *** Submitted as https://code.google.com/p/go/source/detail?r=2facb9da08d5 ***
> 
> runtime: add throwgo
> 
> Fixes issue 8380.
> 
> Also update hashmap.go to use throwgo rather than panic.
> 
> LGTM=khr
> R=khr, rsc
> CC=golang-codereviews
> https://codereview.appspot.com/115860045

I'm a bit late to the party, but I'd like to mention that the other functions in
stubs.go (gogetcallerpc, goeq, gohash, gocas, gomemeq) use "go" as prefix, not
suffix. ,

[dave_cheney.net, 2014-07-22 00:14:45]

I agree, this was a mistake on my part. I will prepare a change to correct
this tonight.


On Fri, Jul 18, 2014 at 9:31 PM, <elias.naur@gmail.com> wrote:

> On 2014/07/18 06:30:56, dfc wrote:
>
>> *** Submitted as
>>
> https://code.google.com/p/go/source/detail?r=2facb9da08d5 ***
>
>  runtime: add throwgo
>>
>
>  Fixes issue 8380.
>>
>
>  Also update hashmap.go to use throwgo rather than panic.
>>
>
>  LGTM=khr
>> R=khr, rsc
>> CC=golang-codereviews
>> https://codereview.appspot.com/115860045
>>
>
> I'm a bit late to the party, but I'd like to mention that the other
> functions in stubs.go (gogetcallerpc, goeq, gohash, gocas, gomemeq) use
> "go" as prefix, not suffix. ,
>
> https://codereview.appspot.com/115860045/
>