Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(9447)

Issue 11569043: code review 11569043: runtime: prevent sysmon from polling network excessivly (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by dvyukov
Modified:
10 years, 9 months ago
Reviewers:
iant
CC:
golang-dev, iant
Visibility:
Public.

Description

runtime: prevent sysmon from polling network excessivly If the network is not polled for 10ms, sysmon starts polling network on every iteration (every 20us) until another thread blocks in netpoll. Fixes issue 5922.

Patch Set 1 #

Patch Set 2 : diff -r 353ca41927f1 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 353ca41927f1 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r c2eb7db7c980 https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/pkg/runtime/proc.c View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4
dvyukov
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
10 years, 9 months ago (2013-07-19 12:05:36 UTC) #1
iant
LGTM I'm guessing that we want this in 1.1.2. If you agree, please open an ...
10 years, 9 months ago (2013-07-19 13:14:05 UTC) #2
dvyukov
On 2013/07/19 13:14:05, iant wrote: > LGTM > > I'm guessing that we want this ...
10 years, 9 months ago (2013-07-19 13:45:17 UTC) #3
dvyukov
10 years, 9 months ago (2013-07-19 13:45:48 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=6b3c351c7fe6 ***

runtime: prevent sysmon from polling network excessivly
If the network is not polled for 10ms, sysmon starts polling network
on every iteration (every 20us) until another thread blocks in netpoll.
Fixes issue 5922.

R=golang-dev, iant
CC=golang-dev
https://codereview.appspot.com/11569043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b