Descriptiongo.crypto/openpgp: sign in NewEntity, not SerializePrivate.
NewEntity was intended to return an entity that could be
further configured before SerializePrivate. However, based
on the referenced bug, this is clearly confusing people.
This change causes the needed signatures to be calculated
in NewEntity rather than SerializePrivate. This means that
calling other functions on the new entity (like Serialize)
will work, but also means that anyone who was doing further
customisation of the entity will need to doing the signing
themselves now.
Fixes issue 6483.
Patch Set 1 #Patch Set 2 : code review 115560043: go.crypto/openpgp: sign in NewEntity, not SerializePrivate. #Patch Set 3 : diff -r 2a61df2221b6 https://code.google.com/p/go.crypto/ #
|