Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(385)

Issue 115560043: go.crypto/openpgp: sign in NewEntity, not SerializePrivate.

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 8 months ago by agl1
Modified:
9 years, 8 months ago
Reviewers:
Visibility:
Public.

Description

go.crypto/openpgp: sign in NewEntity, not SerializePrivate. NewEntity was intended to return an entity that could be further configured before SerializePrivate. However, based on the referenced bug, this is clearly confusing people. This change causes the needed signatures to be calculated in NewEntity rather than SerializePrivate. This means that calling other functions on the new entity (like Serialize) will work, but also means that anyone who was doing further customisation of the entity will need to doing the signing themselves now. Fixes issue 6483.

Patch Set 1 #

Patch Set 2 : code review 115560043: go.crypto/openpgp: sign in NewEntity, not SerializePrivate. #

Patch Set 3 : diff -r 2a61df2221b6 https://code.google.com/p/go.crypto/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -13 lines) Patch
M openpgp/keys.go View 5 chunks +14 lines, -12 lines 0 comments Download
M openpgp/write_test.go View 2 chunks +18 lines, -1 line 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b