code review 11524045: misc/emacs: replace our go-goto-opening-parenthesis wit...

misc/emacs: replace our go-goto-opening-parenthesis with backward-up-list

[Dominik Honnef, 2013-07-24 15:47:24]

Hello adonovan@google.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[adonovan, 2013-07-24 16:21:23]

LGTM

https://codereview.appspot.com/11524045/diff/5001/misc/emacs/go-mode.el
File misc/emacs/go-mode.el (right):

https://codereview.appspot.com/11524045/diff/5001/misc/emacs/go-mode.el#newco...
misc/emacs/go-mode.el:90: ;; Move up one level of parentheses. The optional
argument ARG has no
You could remove all documentation of ARG and just rename it to legacy-unused or
similar.

What code requires this compatibility?  Some users' .emacs files?

https://codereview.appspot.com/11524045/diff/5001/misc/emacs/go-mode.el#newco...
misc/emacs/go-mode.el:100: (error nil)))
Consider catching the specific error to avoid concealing latent bugs.

[Dominik Honnef, 2013-07-24 16:42:29]

On 2013/07/24 16:21:23, adonovan wrote:
> LGTM
> 
> https://codereview.appspot.com/11524045/diff/5001/misc/emacs/go-mode.el
> File misc/emacs/go-mode.el (right):
> 
>
https://codereview.appspot.com/11524045/diff/5001/misc/emacs/go-mode.el#newco...
> misc/emacs/go-mode.el:90: ;; Move up one level of parentheses. The optional
> argument ARG has no
> You could remove all documentation of ARG and just rename it to legacy-unused
or
> similar.

Done.

> 
> What code requires this compatibility?  Some users' .emacs files?

Some user's .emacs file, or someone's package that makes use of go-mode
functions. Basically it's a public function, someone might be using it.
Personally I think the odds of someone actually using the optional argument are
0%, but who knows… 

> 
>
https://codereview.appspot.com/11524045/diff/5001/misc/emacs/go-mode.el#newco...
> misc/emacs/go-mode.el:100: (error nil)))
> Consider catching the specific error to avoid concealing latent bugs.

Done.

[adonovan, 2013-07-24 17:48:06]

*** Submitted as https://code.google.com/p/go/source/detail?r=5990f8211e89 ***

misc/emacs: replace our go-goto-opening-parenthesis with backward-up-list

R=adonovan
CC=golang-dev
https://codereview.appspot.com/11524045

Committer: Alan Donovan <adonovan@google.com>