Issue 115170043: code review 115170043: go-tour: add log.Fatal to HTTP handlers exercise

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 115170043: code review 115170043: go-tour: add log.Fatal to HTTP handlers exercise (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 9 months ago by adg

Modified:
9 years, 9 months ago

Reviewers:

CC:
campoy, golang-codereviews

Visibility:
Public.

Description

go-tour: add log.Fatal to HTTP handlers exercise This helps people diagnose the ListenAndServe error.

Patch Set 1 #

Patch Set 2 : diff -r 0e45f2a00d7f https://code.google.com/p/go-tour #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	content/prog/tour/exercise-http-handlers.go	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

adg

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go-tour

9 years, 9 months ago (2014-07-22 07:17:18 UTC) #1

adg

9 years, 9 months ago (2014-07-22 07:30:15 UTC) #2

*** Submitted as https://code.google.com/p/go-tour/source/detail?r=625a9fe542b3
***

go-tour: add log.Fatal to HTTP handlers exercise

This helps people diagnose the ListenAndServe error.

TBR=campoy
R=golang-codereviews
CC=golang-codereviews
https://codereview.appspot.com/115170043

Expand All Messages | Collapse All Messages