Issue 114920043: code review 114920043: go-tour: tweaks to basics section

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 114920043: code review 114920043: go-tour: tweaks to basics section (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 9 months ago by adg

Modified:
9 years, 9 months ago

Reviewers:
campoy

CC:
campoy, golang-codereviews

Visibility:
Public.

Patch Set 2 : diff -r 8d4ec52dae67 https://code.google.com/p/go-tour #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -11 lines)			Patch
M	content/basics.article	View	1	6 chunks	+21 lines, -7 lines	0 comments	Download
M	content/prog/tour/imports.go	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	content/prog/tour/variables.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/prog/tour/variables-with-initializers.go	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adg

Hello campoy (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go-tour

9 years, 9 months ago (2014-07-17 07:32:23 UTC) #1

campoy

LGTM https://codereview.appspot.com/114920043/diff/1/content/basics.article File content/basics.article (right): https://codereview.appspot.com/114920043/diff/1/content/basics.article#newcode85 content/basics.article:85: Go's return values may be named and act ...

9 years, 9 months ago (2014-07-17 18:21:06 UTC) #2

adg

9 years, 9 months ago (2014-07-18 00:14:21 UTC) #3

*** Submitted as https://code.google.com/p/go-tour/source/detail?r=91f9594fc692
***

go-tour: tweaks to basics section

LGTM=campoy
R=campoy
CC=golang-codereviews
https://codereview.appspot.com/114920043

https://codereview.appspot.com/114920043/diff/1/content/basics.article
File content/basics.article (right):

https://codereview.appspot.com/114920043/diff/1/content/basics.article#newcode85
content/basics.article:85: Go's return values may be named and act just like
variables.
On 2014/07/17 18:21:05, campoy wrote:
> s/may/can/

may is definitely the word i want to use here.

https://codereview.appspot.com/114920043/diff/1/content/basics.article#newcod...
content/basics.article:139: The example shows variable of several types, andi
also that variable declarations may be "factored" into blocks just like import
statements.
On 2014/07/17 18:21:05, campoy wrote:
> s/variable/variables/; s/andi/and/

Done.

Expand All Messages | Collapse All Messages