code review 11490043: cmd/cgo: don't emit #pragma declarations when using gccgo

cmd/cgo: don't emit #pragma declarations when using gccgo

Update issue 5905

Don't emit #pragma cgo_ldflag and cgo_import_static
declarations that gccgo doesn't understand and can't use.

[iant, 2013-07-18 00:56:37]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[rsc, 2013-07-18 00:58:31]

LGTM

[bradfitz, 2013-07-18 01:00:11]

LGTM
 On Jul 18, 2013 10:56 AM, <iant@golang.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> cmd/cgo: don't emit #pragma declarations when using gccgo
>
> Update issue 5905
>
> Don't emit #pragma cgo_ldflag and cgo_import_static
> declarations that gccgo doesn't understand and can't use.
>
> Please review this at
https://codereview.appspot.**com/11490043/<https://codereview.appspot.com/114...
>
> Affected files:
>   M src/cmd/cgo/out.go
>
>
> Index: src/cmd/cgo/out.go
> ==============================**==============================**=======
> --- a/src/cmd/cgo/out.go
> +++ b/src/cmd/cgo/out.go
> @@ -32,7 +32,7 @@
>         fflg := creat(*objDir + "_cgo_flags")
>         for k, v := range p.CgoFlags {
>                 fmt.Fprintf(fflg, "_CGO_%s=%s\n", k, strings.Join(v, " "))
> -               if k == "LDFLAGS" {
> +               if k == "LDFLAGS" && !*gccgo {
>                         for _, arg := range v {
>                                 fmt.Fprintf(fc, "#pragma cgo_ldflag %q\n",
> arg)
>                         }
> @@ -105,7 +105,10 @@
>                         fmt.Fprintf(fm, "extern char %s[];\n", n.C)
>                         fmt.Fprintf(fm, "void *_cgohack_%s = %s;\n\n",
> n.C, n.C)
>
> -                       fmt.Fprintf(fc, "#pragma cgo_import_static %s\n",
> n.C)
> +                       if !*gccgo {
> +                               fmt.Fprintf(fc, "#pragma cgo_import_static
> %s\n", n.C)
> +                       }
> +
>                         fmt.Fprintf(fc, "extern byte *%s;\n", n.C)
>
>                         cVars[n.C] = true
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[iant, 2013-07-18 01:02:25]

*** Submitted as https://code.google.com/p/go/source/detail?r=fad8f3d28e19 ***

cmd/cgo: don't emit #pragma declarations when using gccgo

Update issue 5905

Don't emit #pragma cgo_ldflag and cgo_import_static
declarations that gccgo doesn't understand and can't use.

R=golang-dev, rsc, bradfitz
CC=golang-dev
https://codereview.appspot.com/11490043