code review 114890043: A+C: snyh (individual CLA)

A+C: snyh (individual CLA)

Generated by a+c.

[minux, 2014-07-17 05:35:44]

Hello gobot@swtch.com (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[minux, 2014-07-17 05:35:58]

*** Submitted as https://code.google.com/p/go/source/detail?r=cec300ebce0b ***

A+C: snyh (individual CLA)

Generated by a+c.

R=gobot
CC=golang-codereviews
https://codereview.appspot.com/114890043

[iant2, 2014-07-17 08:43:44]

We normally require full names, so I'm not sure this is acceptable.

Ian
On Jul 16, 2014 10:35 PM, <minux@golang.org> wrote:

> Reviewers: gobot_swtch.com,
>
> Message:
> Hello gobot@swtch.com (cc: golang-codereviews@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> A+C: snyh (individual CLA)
>
> Generated by a+c.
>
> Please review this at https://codereview.appspot.com/114890043/
>
> Affected files (+2, -0 lines):
>   M AUTHORS
>   M CONTRIBUTORS
>
>
> Index: AUTHORS
> ===================================================================
> --- a/AUTHORS
> +++ b/AUTHORS
> @@ -380,6 +380,7 @@
>  Shenghou Ma <minux.ma@gmail.com>
>  Shivakumar GN <shivakumar.gn@gmail.com>
>  Simon Whitehead <chemnova@gmail.com>
> +snyh <snyh@snyh.org>
>  Sokolov Yura <funny.falcon@gmail.com>
>  Spring Mc <heresy.mc@gmail.com>
>  StalkR <stalkr@stalkr.net>
> Index: CONTRIBUTORS
> ===================================================================
> --- a/CONTRIBUTORS
> +++ b/CONTRIBUTORS
> @@ -526,6 +526,7 @@
>  Shenghou Ma <minux@golang.org> <minux.ma@gmail.com>
>  Shivakumar GN <shivakumar.gn@gmail.com>
>  Simon Whitehead <chemnova@gmail.com>
> +snyh <snyh@snyh.org>
>  Sokolov Yura <funny.falcon@gmail.com>
>  Spring Mc <heresy.mc@gmail.com>
>  StalkR <stalkr@stalkr.net>
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[rsc, 2014-07-17 17:24:57]

This isn't okay. I will reach out to snyh to get this corrected, or else we
will roll back this CL and the code change.

Thanks.
Russ