Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://khr%40golang.org@code.google.com/p/go/
LGTM On Jul 16, 2014 5:07 PM, <khr@golang.org> wrote: > Reviewers: golang-codereviews, > > Message: > Hello golang-codereviews@googlegroups.com, > > I'd like you to review this change to > https://khr%40golang.org@code.google.com/p/go/ > > > Description: > runtime: align gomemeq return value correctly > > Fixes issue 8378 > > Please review this at https://codereview.appspot.com/114880043/ > > Affected files (+2, -2 lines): > M src/pkg/runtime/asm_amd64p32.s > > > Index: src/pkg/runtime/asm_amd64p32.s > =================================================================== > --- a/src/pkg/runtime/asm_amd64p32.s > +++ b/src/pkg/runtime/asm_amd64p32.s > @@ -730,12 +730,12 @@ > MOVL count+8(FP), BX > JMP runtime·memeqbody(SB) > > -TEXT runtime·gomemeq(SB),NOSPLIT,$0-13 > +TEXT runtime·gomemeq(SB),NOSPLIT,$0-17 > MOVL a+0(FP), SI > MOVL b+4(FP), DI > MOVL size+8(FP), BX > CALL runtime·memeqbody(SB) > - MOVB AX, ret+12(FP) > + MOVB AX, ret+16(FP) > RET > > // eqstring tests whether two strings are equal. > > > -- > You received this message because you are subscribed to the Google Groups > "golang-codereviews" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to golang-codereviews+unsubscribe@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. >
*** Submitted as https://code.google.com/p/go/source/detail?r=8e05add24c7e *** runtime: align gomemeq return value correctly Fixes issue 8378 LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://codereview.appspot.com/114880043