code review 114760044: go-tour: add a slide on append

go-tour: add a slide on append

[francesc, 2014-07-11 21:47:46]

Hello adg@golang.org (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go-tour

[adg, 2014-07-14 06:35:26]

https://codereview.appspot.com/114760044/diff/50001/content/moretypes.article
File content/moretypes.article (right):

https://codereview.appspot.com/114760044/diff/50001/content/moretypes.article...
content/moretypes.article:120: The main difference between arrays and slices is
that
This line and the bullets is confusing. It makes it sound like there are arrays
and there are slices and they are separate things, but in slices are backed by
arrays. I suggest just deleting it.

https://codereview.appspot.com/114760044/diff/50001/content/moretypes.article...
content/moretypes.article:125: We already saw that we can shrink a slice by
slicing it.
delete

https://codereview.appspot.com/114760044/diff/50001/content/moretypes.article...
content/moretypes.article:127: To add elements to a slice we use the `append`
builtin function.
It is common to append new elements to a slice, and so Go provides a built-in
`append` function.

https://codereview.appspot.com/114760044/diff/50001/content/moretypes.article...
content/moretypes.article:129: The first parameter of `append` is a slice of any
given type T, and the rest of
above this, provide a function signature

func append([]T, ...T)

https://codereview.appspot.com/114760044/diff/50001/content/moretypes.article...
content/moretypes.article:129: The first parameter of `append` is a slice of any
given type T, and the rest of
link to http://golang.org/pkg/builtin/#append

https://codereview.appspot.com/114760044/diff/50001/content/moretypes.article...
content/moretypes.article:129: The first parameter of `append` is a slice of any
given type T, and the rest of
s/any given//

https://codereview.appspot.com/114760044/diff/50001/content/moretypes.article...
content/moretypes.article:130: parameters are values of that type T.
are T values to append to the slice.

https://codereview.appspot.com/114760044/diff/50001/content/moretypes.article...
content/moretypes.article:133: original slice plus the given parameters.
s/given parameters/provided values/.

https://codereview.appspot.com/114760044/diff/50001/content/moretypes.article...
content/moretypes.article:134: 
say something about how append allocates a new backing array if the existing one
is too small for the new elements

https://codereview.appspot.com/114760044/diff/50001/content/prog/tour/append.go
File content/prog/tour/append.go (right):

https://codereview.appspot.com/114760044/diff/50001/content/prog/tour/append....
content/prog/tour/append.go:9: // append works on nil slices.
proper capitalization please

https://codereview.appspot.com/114760044/diff/50001/content/prog/tour/append....
content/prog/tour/append.go:20: }
also throw in

// we can also append another slice to the slice
a = append(a, []int{5, 6, 7}...)

[campoy, 2014-07-14 20:55:53]

https://codereview.appspot.com/114760044/diff/50001/content/moretypes.article
File content/moretypes.article (right):

https://codereview.appspot.com/114760044/diff/50001/content/moretypes.article...
content/moretypes.article:120: The main difference between arrays and slices is
that
On 2014/07/14 06:35:26, adg wrote:
> This line and the bullets is confusing. It makes it sound like there are
arrays
> and there are slices and they are separate things, but in slices are backed by
> arrays. I suggest just deleting it.

Done.

https://codereview.appspot.com/114760044/diff/50001/content/moretypes.article...
content/moretypes.article:125: We already saw that we can shrink a slice by
slicing it.
On 2014/07/14 06:35:26, adg wrote:
> delete

Done.

https://codereview.appspot.com/114760044/diff/50001/content/moretypes.article...
content/moretypes.article:127: To add elements to a slice we use the `append`
builtin function.
On 2014/07/14 06:35:26, adg wrote:
> It is common to append new elements to a slice, and so Go provides a built-in
> `append` function.

Done.

https://codereview.appspot.com/114760044/diff/50001/content/moretypes.article...
content/moretypes.article:130: parameters are values of that type T.
On 2014/07/14 06:35:26, adg wrote:
> are T values to append to the slice.

Done.

https://codereview.appspot.com/114760044/diff/50001/content/moretypes.article...
content/moretypes.article:133: original slice plus the given parameters.
On 2014/07/14 06:35:26, adg wrote:
> s/given parameters/provided values/.

Done.

https://codereview.appspot.com/114760044/diff/50001/content/moretypes.article...
content/moretypes.article:134: 
On 2014/07/14 06:35:26, adg wrote:
> say something about how append allocates a new backing array if the existing
one
> is too small for the new elements

Done.

[adg, 2014-07-15 00:36:30]

LGTM

https://codereview.appspot.com/114760044/diff/90001/content/moretypes.article
File content/moretypes.article (right):

https://codereview.appspot.com/114760044/diff/90001/content/moretypes.article...
content/moretypes.article:135: The returned slice will point to the newly
allocated array.
merge this with the above paragraph. otherwise it looks like it's always a new
slice

[campoy, 2014-07-15 03:42:10]

https://codereview.appspot.com/114760044/diff/90001/content/moretypes.article
File content/moretypes.article (right):

https://codereview.appspot.com/114760044/diff/90001/content/moretypes.article...
content/moretypes.article:135: The returned slice will point to the newly
allocated array.
On 2014/07/15 00:36:30, adg wrote:
> merge this with the above paragraph. otherwise it looks like it's always a new
> slice

Done.

[francesc, 2014-07-15 03:42:50]

*** Submitted as https://code.google.com/p/go-tour/source/detail?r=f4d3bfa678ba
***

go-tour: add a slide on append

LGTM=adg
R=adg, campoy
CC=golang-codereviews
https://codereview.appspot.com/114760044