code review 11457044: misc/emacs: Make godef-jump behave more like find-tag b...

misc/emacs: Make godef-jump behave more like find-tag by supporting pop-tag-mark

Push point to the find-tag marker ring to support pop-tag-mark.

Fixes issue 5804.

[Dominik Honnef, 2013-07-24 14:44:48]

Hello adonovan@google.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[adonovan, 2013-07-24 14:52:21]

LGTM

https://codereview.appspot.com/11457044/diff/4002/misc/emacs/go-mode.el
File misc/emacs/go-mode.el (right):

https://codereview.appspot.com/11457044/diff/4002/misc/emacs/go-mode.el#newcode8
misc/emacs/go-mode.el:8: (require 'etags)
Also: (require 'ring)

It's good practice to declare all your direct dependencies rather than rely on
the transitivity of "require", as this makes your code more robust against later
refactorings.

[Dominik Honnef, 2013-07-24 14:56:49]

On 2013/07/24 14:52:21, adonovan wrote:
> LGTM
> 
> https://codereview.appspot.com/11457044/diff/4002/misc/emacs/go-mode.el
> File misc/emacs/go-mode.el (right):
> 
>
https://codereview.appspot.com/11457044/diff/4002/misc/emacs/go-mode.el#newcode8
> misc/emacs/go-mode.el:8: (require 'etags)
> Also: (require 'ring)
> 
> It's good practice to declare all your direct dependencies rather than rely on
> the transitivity of "require", as this makes your code more robust against
later
> refactorings.

Done.

[adonovan, 2013-07-24 15:20:56]

*** Submitted as https://code.google.com/p/go/source/detail?r=a5e5a59efd47 ***

misc/emacs: Make godef-jump behave more like find-tag by supporting pop-tag-mark

Push point to the find-tag marker ring to support pop-tag-mark.

Fixes issue 5804.

R=adonovan
CC=golang-dev
https://codereview.appspot.com/11457044

Committer: Alan Donovan <adonovan@google.com>